From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433F7198A33 for ; Thu, 19 Sep 2024 17:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726766660; cv=none; b=gTLgvU+HzumwgXnhVasw0upf7mEiNixFG65UXEWHgMZwfgoq2jgUyAqvqwPJQZTcbtbKVGK2FcE+OAhtbqwR5+ZizRGKq9rku8om9ctXfjLYlq0VE+b4f4tfFpr8E3zJAajZKNw1Y/5LQXc/UbxA323UGUnq/LtJjrllNMx5Lao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726766660; c=relaxed/simple; bh=9UPuffiJEpTMQNa/RgZa0HUXQrmRq+s6vEz5epvuDDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PFxZiLQdmkx2FGvbcit5RgiYhZ/UXtOHpg4CPZLPGskDoGQXadf5FsSk6/Dz+pKLL8hepSSbZfcL8vxRhWr82qsXtY4+wHyI2l37g8D2fCZaNyGx7Fl609U20nOR7qiBuX5axS61RpMEl13Uvt4XcRchXrTGf+ias9Vp+IxntTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=dJV4egmH; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="dJV4egmH" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2053525bd90so12240005ad.0 for ; Thu, 19 Sep 2024 10:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1726766657; x=1727371457; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=CNbiO/82DP9u2sWzbvovvrFbtPlTZFQedx6KNu76pJM=; b=dJV4egmHLlbQy+NSqL3cQ3Y4tDnFtWPd2q65mYmVVOZISRDzjoDfMvWdl4ov4xXTjD vIzLieHmCrB9q5t+7shCsKJeLNkFqZOZ+y7ngExJUkiKzD48fkUDjfM4iOS1Rx/++pbc Y72AFHiIy+PDuMTmwgLIA34CVK76cCRXAPI4B4LFdRz31o2SsciFsywGwGVvKP4VEZ7I pY3D0i3abSPJhHOEwtfGdDr9rDhLzQrglsonSANfMYom2RrY5OENikIzkcG/bLv6Nl0P NMas6EkDxDcGHkhyjL/LfXrmkz515avu/UoFv/fM287Tc86nqs/a0Qnv4kiH4DGwi9W1 nguA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726766657; x=1727371457; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CNbiO/82DP9u2sWzbvovvrFbtPlTZFQedx6KNu76pJM=; b=LBIUI4oFuAr1u/MjHarlnSxJFyCdOMriPp2LeHPSqwV6k0jZE2dwwTRGHy7SvRgE0j FNx5Tu2oI4OwY96paKN1Kf7GNKYpy4ivHPXTW3AsCIyjaKg8/xkTjEexdCwYw0gMXOEX m88s5LKxjo/Df76qQT39wZZ74QvoGXG1PpDtXL/R2TqGmL7/lh/zhrIqRh9+VNrAthAg L34hGvf0Bll2mwOi71kgW4DH/Vyh+HfCI2DPjiVZPoIB08bV6DDt/6UKhLWLmDgtsdSq YF/aY1aPPh/lkEn0ZtkZZLUUdjTefKRC5kQtqQ1H3gbJ9GwrcHkfC9kIMKLOWISBoHO+ wkUg== X-Forwarded-Encrypted: i=1; AJvYcCWcqoZx6G3Vbq6NdAGgcAKOmARE6PecJYsBirVMi88Nsxq3ejPdkS0Fcg63c4fdlutjVt1+1g02RZ7N@vger.kernel.org X-Gm-Message-State: AOJu0YzTFwSkQTJWBScXhWfg5IF48Iid2z1bBiBJmHFmcxjVkFV3tHKf mAZftsyZC7HIJPjmWzhodBrREecwnOzTnGTNBs8/mJGJs3cg8tpsSAHPo+6lC6Q= X-Google-Smtp-Source: AGHT+IHPfY4TEkVvMUVnLR9vZZuyYLKJtFhdGuuG5hbLTNkoQGtK2vgWZ0VNokhT+DVllzTi43tO6w== X-Received: by 2002:a17:902:ecc1:b0:206:9519:1821 with SMTP id d9443c01a7336-208d8397bf2mr1158685ad.14.1726766657486; Thu, 19 Sep 2024 10:24:17 -0700 (PDT) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-207a09593f6sm73088405ad.220.2024.09.19.10.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 10:24:16 -0700 (PDT) Date: Thu, 19 Sep 2024 10:24:14 -0700 From: Mohamed Khalfella To: Moshe Shemesh Cc: Przemek Kitszel , yzhong@purestorage.com, Shay Drori , Saeed Mahameed , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tariq Toukan Subject: Re: [PATCH v2 0/1] net/mlx5: Added cond_resched() to crdump collection Message-ID: References: <20240829213856.77619-1-mkhalfella@purestorage.com> <43e7d936-f3c6-425a-b2ff-487c88905a0f@intel.com> <36b5d976-1fcb-45b9-97dd-19f048997588@nvidia.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2024-09-04 20:38:13 -0700, Mohamed Khalfella wrote: > On 2024-08-30 12:51:43 +0300, Moshe Shemesh wrote: > > > > > > On 8/30/2024 10:08 AM, Przemek Kitszel wrote: > > > > > > > > On 8/30/24 01:58, Mohamed Khalfella wrote: > > >> On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote: > > >>> Changes in v2: > > >>> - Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that > > >>>    usleep_range() should be enough. > > >>> - Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128 > > >>>    iterations. > > >>> > > >>> v1: > > >>> https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@purestorage.com/ > > >>> > > >>> Mohamed Khalfella (1): > > >>>    net/mlx5: Added cond_resched() to crdump collection > > >>> > > >>>   drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++ > > >>>   1 file changed, 4 insertions(+) > > >>> > > >>> -- > > >>> 2.45.2 > > >>> > > >> > > >> Some how I missed to add reviewers were on v1 of this patch. > > >> > > > > > > You did it right, there is need to provide explicit tag, just engaging > > > in the discussion is not enough. v2 is fine, so: > > > Reviewed-by: Przemek Kitszel > > > > Reviewed-by: Moshe Shemesh > > And fixes tag should be: > > Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support") > > Will add the tag in v3. A quick follow up on this patch. I posted v3 [1] of this patch with minor changes. There are no functional differences between v2 and v3 of this patch. The commit messsage on v3 has information why call cond_resched() every 128 iterations, so that could be useful to add. Is there anything I need to do to get v2 or v3 of this patch merged? [1] https://lore.kernel.org/all/20240905040249.91241-1-mkhalfella@purestorage.com/