Re: of c4iw_fill_res_qp_entry

Leon Romanovsky
2024-10-06T14:06:02Z

On Fri, Oct 04, 2024 at 02:16:08PM +0000, Dr. David Alan Gilbert wrote:
> Hi,
> One of my scripts noticed that c4iw_fill_res_qp_entry is not called
> anywhere; It came from:
>
> commit 5cc34116ccec60032dbaa92768f41e95ce2d8ec7
> Author: Maor Gottlieb <maorg@mellanox.com>
> Date: Tue Jun 23 14:30:38 2020 +0300
>
> RDMA: Add dedicated QP resource tracker function
>
> I was going to send a patch to deadcode it, but is it really a bug and
> it should be assigned in c4iw_dev_ops in cxgb4/provider.c ?
>
> (Note I know nothing about the innards of your driver, I'm just spotting
> the unused function).

It is a bug, something like that should be done.
diff --git a/drivers/infiniband/hw/cxgb4/provider.c b/drivers/infiniband/hw/cxgb4/provider.c
index 10a4c738b59f..e059f92d90fd 100644
--- a/drivers/infiniband/hw/cxgb4/provider.c
+++ b/drivers/infiniband/hw/cxgb4/provider.c
@@ -473,6 +473,7 @@ static const struct ib_device_ops c4iw_dev_ops = {
.fill_res_cq_entry = c4iw_fill_res_cq_entry,
.fill_res_cm_id_entry = c4iw_fill_res_cm_id_entry,
.fill_res_mr_entry = c4iw_fill_res_mr_entry,
+ .fill_res_qp_entry = c4iw_fill_res_qp_entry,
.get_dev_fw_str = get_dev_fw_str,
.get_dma_mr = c4iw_get_dma_mr,
.get_hw_stats = c4iw_get_mib,
(END)

>
> Thoughts?
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
>