Re: [PATCH for-next] RDMA/efa: Support CQ receive entries with source GID

["Margolin, Michael" <mrgolin@amazon.com>]

On 8/16/2022 4:56 PM, Leon Romanovsky wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Tue, Aug 09, 2022 at 06:16:36PM +0300, Michael Margolin wrote:
>> Add a parameter for create CQ admin command to set source address on
>> receive completion descriptors. Report capability for this feature
>> through query device verb.
>>
>> Reviewed-by: Firas Jahjah <firasj@amazon.com>
>> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
>> Signed-off-by: Daniel Kranzdorf <dkkranzd@amazon.com>
>> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
>> ---
>>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 6 +++++-
>>  drivers/infiniband/hw/efa/efa_com_cmd.c         | 5 ++++-
>>  drivers/infiniband/hw/efa/efa_com_cmd.h         | 1 +
>>  drivers/infiniband/hw/efa/efa_verbs.c           | 4 +++-
>>  include/uapi/rdma/efa-abi.h                     | 4 +++-
>>  5 files changed, 16 insertions(+), 4 deletions(-)
> <...>
>
>> diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.h b/drivers/infiniband/hw/efa/efa_com_cmd.h
>> index c33010bbf9e8..c6234336543d 100644
>> --- a/drivers/infiniband/hw/efa/efa_com_cmd.h
>> +++ b/drivers/infiniband/hw/efa/efa_com_cmd.h
>> @@ -76,6 +76,7 @@ struct efa_com_create_cq_params {
>>       u16 eqn;
>>       u8 entry_size_in_bytes;
>>       bool interrupt_mode_enabled;
>> +     bool set_src_addr;
> Please use "u8 xxx : 1" instead of bool in structs.
>
> Thanks

Thanks Leon for your reply.

Is this a convention in the subsystem? This is an internal struct used
only to bind several variables for a function call and I think using
bool makes it more readable.

Of course if it's essential I will change this.


Michael