From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5414EC432C0 for ; Sun, 17 Nov 2019 15:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C986206D3 for ; Sun, 17 Nov 2019 15:28:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="szbkSJbV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbfKQP25 (ORCPT ); Sun, 17 Nov 2019 10:28:57 -0500 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:41198 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbfKQP25 (ORCPT ); Sun, 17 Nov 2019 10:28:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1574004536; x=1605540536; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=WHWsOINgMarlEDm0f02H983ywgwXKWtCbSQ4LBiTABs=; b=szbkSJbV444DVlI4CNece5tDaByyBhcUD//pUPxbcukTJy65wo8e9oey SXkK8FNCE9SAmnDe/hQRL/n2tmVmnuPcxGedGg2XLdR0TENDeYt/ydcEp mxtPUR5LZImbUTxuA08HVi4rFDZlk6iSZJ2BYQKGiEussOobXA1IXdU+D E=; IronPort-SDR: 8LTLXDbACEMr8sqBGd2qIiwPRkh98omGIUogT7MHD0HtMdlm6eKX+x9QSTOzUnU5592+AcQqXQ X0PKcKNhF11g== X-IronPort-AV: E=Sophos;i="5.68,316,1569283200"; d="scan'208";a="8514090" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 17 Nov 2019 15:28:52 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com (Postfix) with ESMTPS id A6AFCA2071; Sun, 17 Nov 2019 15:28:51 +0000 (UTC) Received: from EX13D19EUB003.ant.amazon.com (10.43.166.69) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 17 Nov 2019 15:28:51 +0000 Received: from 8c85908914bf.ant.amazon.com (10.43.161.189) by EX13D19EUB003.ant.amazon.com (10.43.166.69) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 17 Nov 2019 15:28:47 +0000 Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion To: CC: David Miller , , , , References: <20191115201225.92888-1-lrizzo@google.com> <20191116.131058.1856199123293908506.davem@davemloft.net> From: Gal Pressman Message-ID: Date: Sun, 17 Nov 2019 17:28:42 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191116.131058.1856199123293908506.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.161.189] X-ClientProxiedBy: EX13D23UWA004.ant.amazon.com (10.43.160.72) To EX13D19EUB003.ant.amazon.com (10.43.166.69) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 16/11/2019 23:10, David Miller wrote: > From: Luigi Rizzo > Date: Fri, 15 Nov 2019 12:12:25 -0800 > >> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the >> total number of entries in the rx classifier table. Surprisingly, mlx4 >> is missing this part (in principle ethtool could still move forward and >> try the insert). >> >> Tested: compiled and run command: >> phh13:~# ethtool -N eth1 flow-type udp4 queue 4 >> Added rule with ID 255 >> >> Signed-off-by: Luigi Rizzo >> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76 > > Luigi, _always_ CC: the appropriate maintainer when making changes to the > kernel, as per the top-level MAINTAINERS file. You should also remove the Change-Id tag before submission.