From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94BA0275104 for ; Thu, 24 Jul 2025 08:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753347183; cv=none; b=ha8zFsVgYHSlEIBl1e8p9KEMA/uR+RkNVkS8KEel0f4ZxLya4F0p7vLCCP7f+mlnY4HHv+UkhEhhXeqKGEyXRsLphutA15d1xXp8KZsJP1NnuHmYKu6fW4l4pzjC+3oZnZ13CpkblUnihqABBwuCwZTWwzMlaR7MUsfG/2gCLuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753347183; c=relaxed/simple; bh=IRi5oEmDJUpMIypzUFpLa5hQ8fOukFELiqlwbtSM4s0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=msi4HbO2tsGb3pyKHRxfHiRIyRTqrEREYjZ+Z/DfJsIbK9qXIb8OeYz9VKrz2spVRdDm4lh/9ha+r+itBs6llj2cE6EqPV3mqrAoASZviidQHv1jsw5DIQboIrrrSMOw7lq9MdDkLRQ8MwhlvtY3MvW2Lu+djQJtRXhZ4RFQfpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EQtU3pZK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EQtU3pZK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753347180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eSRWHNR3oSryq2XtU/spTQx/p9VSczkNbYfeDDaHpfg=; b=EQtU3pZKsVcqalR19MUJ3IPfcgJkxvCcvkv1hHYnmA1IJCW8sem4JY+9WN+b/zWmR+CAbA Mj/lHor23rCjzbThtd8lgbGcMR3JvKe4BnsuOUF2lmnaK1ZxNbEWLmoPZ0aWOmwmvOb7FZ hFWbBKw2ym+ZNMxDKl0ZNnbxI6fzU7M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-bP6bYqnYMg2PsA_uB9HhXA-1; Thu, 24 Jul 2025 04:52:59 -0400 X-MC-Unique: bP6bYqnYMg2PsA_uB9HhXA-1 X-Mimecast-MFC-AGG-ID: bP6bYqnYMg2PsA_uB9HhXA_1753347178 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a5058f9ef4so275399f8f.2 for ; Thu, 24 Jul 2025 01:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753347178; x=1753951978; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eSRWHNR3oSryq2XtU/spTQx/p9VSczkNbYfeDDaHpfg=; b=Yq6DFIRi5doGU9k9RS5Ifakp+wrdx8zeme3mvb5TVV2NlYzv23LOIYsIubqY12OCtU 9a1sbzQ8TkBarb/+SHeltzxcBkgqEM1IHPWhWVnYM+XXtW10y4GlHUSaBaNwCf7MhKOk WG6PrUbJAFqF2nmv2QU+PApE9ahxVoZvEXpDhUdVUZHgb6p+YRLIWJW1+46ur84JTcP+ FVZjOkjWr0tbdB37FdfdyOo3NWtmZKbLgASMpZrPOqHjktvSDrYAOdzkyQz94VnSWAic YcYahHDIOt4wYUtwHGMcyz7vd8Z0e0z6RX3h3m3IHSmPMpH9gskFFmSvJA2Y4LKYawdn f07g== X-Forwarded-Encrypted: i=1; AJvYcCVVLqBqwjpg3+JXxmTLYRN6MDL9pAYZ5M1y8mSUjHsLmr3r0q1g9f6WAWzapuiNbQQBfjM/gNO7+SH2@vger.kernel.org X-Gm-Message-State: AOJu0YxTRGv5+oW4CbacUhcduBoNTBAELu0Gg7qWQatb0GvqJq1EDbRA ZssupyW53dKb7JVLETzQHMjqOk0XzeXfTM2fw25H1qPC6QJAbZHbukbRAN1HS2PBRE1u5kMoxDV Na4TLi9kUwbkoB5NbRyIfK5cO2D7hziVkIuq1elSr+IhcrAdQ9hJYHx+KpTQ8IwM= X-Gm-Gg: ASbGncvb09XLw0jwZDghxT/5gc7J14jqkd4PR4lmkVmVeFt/w/NaQIYrNIFNk+7Up/6 pW9d4XP/gfEaPVkaeJIZjBT2YzCSdYGZj3Fjaf3RfOFAUbm8qA7bCTPFnOsY/2f2xH/wC19WmRu U7BE1iaZ6GWx4xqaIk60T95aeZGGYJOfDopCgsRVafFvQUqtc3lcDb8FKhK7+F142x3upnYtkj8 qyGuBAsH6pU8LB2t7a0/tQNNIQY+kKSeLEsbSyJ7j6cruj5MYDmN/UM3T/dhc8aNT5qQWiG3ndA q5wbcdHDFEeCQ9PQanNRedhU3EjF3KpmXAuFZWplU/ZP67lpOCb0+P/yv3ir9n3KA1gFUW8NTtC z8teIXuBpm8PtUV/BKkAGePCXxraTxXgEqsTsIux+GO/u4nza6El9F4yWXqnLsaHZ X-Received: by 2002:a05:6000:1884:b0:3a8:30b8:cb93 with SMTP id ffacd0b85a97d-3b768ef953dmr4588635f8f.32.1753347177741; Thu, 24 Jul 2025 01:52:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoD8bQhLMR7nrUTvI3JvUWW9/Pn8ZIBrS4iPYjqfRFSc5RU+yNx7pIBUo5X7x71tBeIaa94w== X-Received: by 2002:a05:6000:1884:b0:3a8:30b8:cb93 with SMTP id ffacd0b85a97d-3b768ef953dmr4588610f8f.32.1753347177191; Thu, 24 Jul 2025 01:52:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:5e00:c941:d6fb:3e30:b42? (p200300d82f1f5e00c941d6fb3e300b42.dip0.t-ipconnect.de. [2003:d8:2f1f:5e00:c941:d6fb:3e30:b42]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b76fcc43c2sm1436739f8f.83.2025.07.24.01.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 01:52:56 -0700 (PDT) Message-ID: Date: Thu, 24 Jul 2025 10:52:54 +0200 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages To: Alistair Popple , Jason Gunthorpe Cc: Matthew Wilcox , Yonatan Maman , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Leon Romanovsky , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ben Skeggs , Michael Guralnik , Or Har-Toov , Daisuke Matsuda , Shay Drory , linux-mm@kvack.org, linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gal Shalom References: <20250718115112.3881129-1-ymaman@nvidia.com> <20250718115112.3881129-2-ymaman@nvidia.com> <20250718144442.GG2206214@ziepe.ca> <7lvduvov3rvfsgixbkyyinnzz3plpp3szxam46ccgjmh6v5d7q@zoz4k723vs3d> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.07.25 06:10, Alistair Popple wrote: > On Wed, Jul 23, 2025 at 12:51:42AM -0300, Jason Gunthorpe wrote: >> On Tue, Jul 22, 2025 at 10:49:10AM +1000, Alistair Popple wrote: >>>> So what is it? >>> >>> IMHO a hack, because obviously we shouldn't require real physical addresses for >>> something the CPU can't actually address anyway and this causes real >>> problems >> >> IMHO what DEVICE PRIVATE really boils down to is a way to have swap >> entries that point to some kind of opaque driver managed memory. >> >> We have alot of assumptions all over about pfn/phys to page >> relationships so anything that has a struct page also has to come with >> a fake PFN today.. > > Hmm ... maybe. To get that PFN though we have to come from either a special > swap entry which we already have special cases for, or a struct page (which is > a device private page) which we mostly have to handle specially anyway. I'm not > sure there's too many places that can sensibly handle a fake PFN without somehow > already knowing it is device-private PFN. > >>> (eg. it doesn't actually work on anything other than x86_64). There's no reason >>> the "PFN" we store in device-private entries couldn't instead just be an index >>> into some data structure holding pointers to the struct pages. So instead of >>> using pfn_to_page()/page_to_pfn() we would use device_private_index_to_page() >>> and page_to_device_private_index(). >> >> It could work, but any of the pfn conversions would have to be tracked >> down.. Could be troublesome. > > I looked at this a while back and I'm reasonably optimistic that this is doable > because we already have to treat these specially everywhere anyway. How would that look like? E.g., we have code like if (is_device_private_entry(entry)) { page = pfn_swap_entry_to_page(entry); folio = page_folio(page); ... folio_get(folio); ... } We could easily stop allowing pfn_swap_entry_to_page(), turning these into non-pfn swap entries. Would it then be something like if (is_device_private_entry(entry)) { page = device_private_entry_to_page(entry); ... } Whereby device_private_entry_to_page() obtains the "struct page" not via the PFN but some other magical (index) value? -- Cheers, David / dhildenb