Re: [PATCH 1/5] IB/core: Make rdma_rw_ctx_init() initialize all used fields

[Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>]

On 06/28/2016 01:51 PM, Christoph Hellwig wrote:
> On Tue, Jun 28, 2016 at 01:25:15PM +0200, Bart Van Assche wrote:
>> -		if (i + 1 < ctx->nr_ops)
>> -			rdma_wr->wr.next = &ctx->map.wrs[i + 1].wr;
>> +		rdma_wr->wr.next = i + 1 < ctx->nr_ops ?
>> +			&ctx->map.wrs[i + 1].wr : NULL;
>
> I think the rdma_rw_ctx_wrs should take care of this as well.

I agree that it is possible to let rdma_rw_ctx_wrs() initialize wr.next 
of the last WR. But if we chose that approach then drivers that call 
rdma_rw_ctx_init() but not rdma_rw_ctx_wrs(), e.g. ib_isert, can end up 
with a last wr.next field that has not been initialized. Hence my 
preference for performing that initialization in rdma_rw_init_mr_wrs() 
and rdma_rw_init_map_wrs().

Bart.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html