From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E1AC433F5 for ; Mon, 11 Apr 2022 09:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237419AbiDKJhf (ORCPT ); Mon, 11 Apr 2022 05:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344438AbiDKJhZ (ORCPT ); Mon, 11 Apr 2022 05:37:25 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25CCD12083 for ; Mon, 11 Apr 2022 02:35:12 -0700 (PDT) Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KcNvQ0xHpzgYbg; Mon, 11 Apr 2022 17:33:22 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Apr 2022 17:35:10 +0800 Received: from [10.40.238.78] (10.40.238.78) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Apr 2022 17:35:10 +0800 Subject: Re: [PATCH for-next] RDMA/hns: Fix the missing device capability flag on the virtual function To: Jason Gunthorpe References: <20220409083523.12097-1-liangwenpeng@huawei.com> <20220409223405.GC2120790@nvidia.com> CC: , , From: Wenpeng Liang Message-ID: Date: Mon, 11 Apr 2022 17:35:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20220409223405.GC2120790@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.238.78] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 2022/4/10 6:34, Jason Gunthorpe wrote: > On Sat, Apr 09, 2022 at 04:35:23PM +0800, Wenpeng Liang wrote: >> If the device is a virtual function, the corresponding device capability >> flag should be set when querying the device. >> >> Fixes: 0b567cde9d7a ("RDMA/hns: Enable RoCE on virtual functions") >> Signed-off-by: Wenpeng Liang >> --- >> drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++ >> 1 file changed, 3 insertions(+) > > No, this is only set if the device implements the _vf_ ops and uses > ipoib > > roce devices never run ipoib > I would unset this flag. Please ignore this patch. Thanks, Wenpeng > Jason > . >