Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org
Subject: Re: Re another alternative to resolve hardened user copy warnings
Date: Tue, 25 Aug 2020 12:12:18 -0500	[thread overview]
Message-ID: <a6ccc179-b23d-3dc4-cff7-57f39e912f13@gmail.com> (raw)
In-Reply-To: <20200825165307.GI24045@ziepe.ca>

On 8/25/20 11:53 AM, Jason Gunthorpe wrote:
> On Tue, Aug 25, 2020 at 11:37:52AM -0500, Bob Pearson wrote:
> 
>> Currently only the rxe driver is exhibiting the issue of kernel
>> warnings during qp create caused by recent kernel changes looking
>> for potential information leaks to user space. The test which
>> triggers this warning is very specific. It occurs when a portion of
>> a kernel object stored in a slab cache is copied to user space and
>> the copied area has not been 'whitelisted' by setting useroffset and
>> usersize parameters for the kmem cache. As already discussed there
>> are two ways to mitigate this
> 
> I think we should just add a uverbs_copy_to() for integers, much like
> netlink does.
> 
> We already have various getters for integers..
> 
> Jason
> 

Perhaps. But I think the proposed fix is good in any case. It gets rid of a bunch of code that doesn't add anything.
The info leak police will come after kmalloc too. It is just a harder problem so your suggestion will still be a good one.

  reply	other threads:[~2020-08-25 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 16:37 Re another alternative to resolve hardened user copy warnings Bob Pearson
2020-08-25 16:53 ` Jason Gunthorpe
2020-08-25 17:12   ` Bob Pearson [this message]
2020-08-25 17:26     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6ccc179-b23d-3dc4-cff7-57f39e912f13@gmail.com \
    --to=rpearsonhpe@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox