From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org, jhack@hpe.com
Subject: Re: [PATCH for-next] RDMA/rxe: Fix packet length checks
Date: Thu, 1 Jun 2023 12:38:45 -0500 [thread overview]
Message-ID: <a724a611-4911-eca6-b489-8fd74e5bc096@gmail.com> (raw)
In-Reply-To: <ZHjWW/O9d2bAET4g@nvidia.com>
On 6/1/23 12:33, Jason Gunthorpe wrote:
> On Wed, May 17, 2023 at 12:22:42PM -0500, Bob Pearson wrote:
>> In rxe_net.c a received packet, from udp or loopback, is passed
>> to rxe_rcv() in rxe_recv.c as a udp packet. I.e. skb->data is
>> pointing at the udp header. But rxe_rcv() makes length checks
>> to verify the packet is long enough to hold the roce headers as
>> if it were a roce packet. I.e. skb->data pointing at the bth
>> header. A runt packet would appear to have 8 more bytes than it
>> actually does which may lead to incorrect behavior.
>>
>> This patch calls skb_pull() to adjust the skb to point at the
>> bth header before calling rxe_rcv() which fixes this error.
>>
>> Fixes: 8700e3e7c485 ("Soft RoCE driver")
>> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
>> ---
>> drivers/infiniband/sw/rxe/rxe_net.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
> Applied to for-rc, thanks
>
> Jason
thanks
prev parent reply other threads:[~2023-06-01 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 17:22 [PATCH for-next] RDMA/rxe: Fix packet length checks Bob Pearson
2023-06-01 17:33 ` Jason Gunthorpe
2023-06-01 17:38 ` Bob Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a724a611-4911-eca6-b489-8fd74e5bc096@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=jhack@hpe.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox