From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Parav Pandit
<pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/rxe: Fix sending out loopback packet on netdev interface.
Date: Sat, 1 Oct 2016 19:10:03 -0400 [thread overview]
Message-ID: <a9d00766-3815-4cb4-77ae-eaedd6e6cf8a@redhat.com> (raw)
In-Reply-To: <1475094282-18352-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]
On 9/28/2016 4:24 PM, Parav Pandit wrote:
> Bug: prepare4 and prepare6 sets loopback mask in pkt_info structure
> instance of skb.
> While xmit_packet and other requester side functions use
> pkt_info from stack. Due to which loopback mask bit set to wrong
> pkt_info structure. This resuilts into sending out packet to actual
> netdev and loopback functionality is broken.
>
> Fix: Similar to other requester side functions, prepare() variants to
> set loopback mask bit on pkt_info structure used by other functions.
> Verified with perftest applications.
>
> Signed-off-by: Parav Pandit <pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
You're commit message had to be largely rewritten, but the code was applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-10-01 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 20:24 [PATCH] IB/rxe: Fix sending out loopback packet on netdev interface Parav Pandit
[not found] ` <1475094282-18352-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-01 23:10 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d00766-3815-4cb4-77ae-eaedd6e6cf8a@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox