From: Mike Snitzer <snitzer@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v1] svcrdma: Increase the server's default RPC/RDMA credit grant
Date: Wed, 1 Oct 2025 15:35:59 -0400 [thread overview]
Message-ID: <aN2Cnz1TrdOO74vb@kernel.org> (raw)
In-Reply-To: <20250926155235.60924-1-cel@kernel.org>
On Fri, Sep 26, 2025 at 11:52:35AM -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Now that the nfsd thread count can scale to more threads, permit
Just trying to appreciate which change(s) paved the way for this
RPCRDMA_MAX_REQUESTS change.
Are you referring to the netlink interface changes Jeff did earlier
this year or something else? (thinking "something else" but...)
Might be useful to update the header to convey which specific
commit(s) made this change possible.
Mike
> individual clients to make more use of those threads. Increase the
> RPC/RDMA per-connection credit grant from 64 to 128 -- same as the
> Linux NFS client.
>
> Simple single client fio-based benchmarking so far shows only
> improvement, no regression.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> include/linux/sunrpc/svc_rdma.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> index 22704c2e5b9b..57f4fd94166a 100644
> --- a/include/linux/sunrpc/svc_rdma.h
> +++ b/include/linux/sunrpc/svc_rdma.h
> @@ -131,7 +131,7 @@ static inline struct svcxprt_rdma *svc_rdma_rqst_rdma(struct svc_rqst *rqstp)
> */
> enum {
> RPCRDMA_LISTEN_BACKLOG = 10,
> - RPCRDMA_MAX_REQUESTS = 64,
> + RPCRDMA_MAX_REQUESTS = 128,
> RPCRDMA_MAX_BC_REQUESTS = 2,
> };
>
> --
> 2.51.0
>
>
next prev parent reply other threads:[~2025-10-01 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 15:52 [PATCH v1] svcrdma: Increase the server's default RPC/RDMA credit grant Chuck Lever
2025-10-01 19:35 ` Mike Snitzer [this message]
2025-10-01 20:18 ` Chuck Lever
2025-10-01 22:44 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN2Cnz1TrdOO74vb@kernel.org \
--to=snitzer@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).