Re: [PATCH rdma-core] vmw_pvrdma: Fix SRQN returned to library

[Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>]

On 2/12/18 10:59 AM, Jason Gunthorpe wrote:
> On Mon, Feb 12, 2018 at 10:42:36AM -0800, Adit Ranadive wrote:
>> From: Aditya Sarwade <asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
>>
>> Here's a fix for the vmw_pvrdma library. It needs to go into the
>> stable branch for 16.0 as well since we can then add it to OFED-4.8-2.
>>

<snip>

> 
> I can't make sense of this.
> 
> Why doesn't grep turn up anything for struct pvrdma_create_srq_resp in
> the kernel?

Do you mean user_pvrdma_create_srq_resp? There isn’t one. 
Its part of our ABI fix up in rdma-core.

> 
> And why do we have two things called srqn in this struct?

It looks like the uverbs in the kernel reports the XRC SRQN in the one of
these while the other gets populated by the driver in the udata here. The SRQN
for a regular SRQ only gets reported in this second srqn field.
I'm not sure why that's the case but we need to report the one from the
driver here then.

> 
> Jason
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html