From: Li Zhijian <lizhijian@fujitsu.com>
To: Xiao Yang <yangx.jy@fujitsu.com>, <linux-rdma@vger.kernel.org>
Cc: <leon@kernel.org>, <jgg@ziepe.ca>
Subject: Re: [PATCH] RDMA/rxe: Remove the duplicate assignment of mr->map_shift
Date: Thu, 27 Oct 2022 17:29:28 +0800 [thread overview]
Message-ID: <abd2f99a-c6b8-137a-4fca-62632e80bce7@fujitsu.com> (raw)
In-Reply-To: <1666855893-145-1-git-send-email-yangx.jy@fujitsu.com>
On 27/10/2022 15:31, Xiao Yang wrote:
> mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init()
> and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init().
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index d4f10c2d1aa7..279fac4c21d0 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -62,7 +62,6 @@ static void rxe_mr_init(int access, struct rxe_mr *mr)
> mr->rkey = mr->ibmr.rkey = rkey;
>
> mr->state = RXE_MR_STATE_INVALID;
> - mr->map_shift = ilog2(RXE_BUF_PER_MAP);
Good catch.
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
> }
>
> static int rxe_mr_alloc(struct rxe_mr *mr, int num_buf)
next prev parent reply other threads:[~2022-10-27 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 7:31 [PATCH] RDMA/rxe: Remove the duplicate assignment of mr->map_shift Xiao Yang
2022-10-27 9:29 ` Li Zhijian [this message]
2022-10-28 18:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd2f99a-c6b8-137a-4fca-62632e80bce7@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox