From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: "Walukiewicz,
Miroslaw"
<Miroslaw.Walukiewicz-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma@vger.kernel.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: double implementation of create QP in the stack.
Date: Tue, 04 Jan 2011 14:43:04 -0800 [thread overview]
Message-ID: <ada1v4sguiv.fsf@cisco.com> (raw)
In-Reply-To: <BE2BFE91933D1B4089447C644860408066C541D1-IGOiFh9zz4wLt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> (Miroslaw Walukiewicz's message of "Thu, 23 Dec 2010 13:43:25 +0000")
> I see that the /drivers/infiniband/core contains two identical
> implementations of the qp create implementation.
> One is in verbs.c
> ...
> And ib_uverbs_cmd.c contains a second one.
> Is there any reason for such double implementation of create_qp().
No good reason I don't think... the two implementations are very nearly
the same, and it would be a nice cleanup to unify the common code into a
single place.
Although with that said I think there are many cleanup opportunities in
the nes drive you could look at too ;) For example consolidate all the
256pbl/4kpbl handling in nes_verbs.c so you don't have variations on the
same code in reg_mr, create_cq, create_qp.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
parent reply other threads:[~2011-01-04 22:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <BE2BFE91933D1B4089447C644860408066C541D1-IGOiFh9zz4wLt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1v4sguiv.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=Miroslaw.Walukiewicz-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox