* Re: double implementation of create QP in the stack.
[not found] ` <BE2BFE91933D1B4089447C644860408066C541D1-IGOiFh9zz4wLt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
@ 2011-01-04 22:43 ` Roland Dreier
0 siblings, 0 replies; only message in thread
From: Roland Dreier @ 2011-01-04 22:43 UTC (permalink / raw)
To: Walukiewicz, Miroslaw; +Cc: linux-rdma@vger.kernel.org
> I see that the /drivers/infiniband/core contains two identical
> implementations of the qp create implementation.
> One is in verbs.c
> ...
> And ib_uverbs_cmd.c contains a second one.
> Is there any reason for such double implementation of create_qp().
No good reason I don't think... the two implementations are very nearly
the same, and it would be a nice cleanup to unify the common code into a
single place.
Although with that said I think there are many cleanup opportunities in
the nes drive you could look at too ;) For example consolidate all the
256pbl/4kpbl handling in nes_verbs.c so you don't have variations on the
same code in reg_mr, create_cq, create_qp.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-04 22:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BE2BFE91933D1B4089447C644860408066C541D1@irsmsx503.ger.corp.intel.com>
[not found] ` <BE2BFE91933D1B4089447C644860408066C541D1-IGOiFh9zz4wLt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-01-04 22:43 ` double implementation of create QP in the stack Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox