From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf Date: Tue, 26 Jan 2010 15:49:19 -0800 Message-ID: References: <4AF3930E.90904@mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: (Yevgeny Petrilin's message of "Tue, 26 Jan 2010 10:21:30 +0200") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yevgeny Petrilin Cc: "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , Liran Liss , Tziporet Koren List-Id: linux-rdma@vger.kernel.org > > I'm a bit confused by these flags. As far as I can tell, the SRIOV flag will be set if and > only if MASTER is set too... so in other words we might as well just have the MASTER and > > SLAVE flags and not have the SRIOV flag at all. > We could have a situation where we have multiple physical functions, without SRIOV. > In this case one of the functions would be MASTER, but not SRIOV Where in the code could that happen? The only place I see the SRIOV or MASTER flag get set is a line like: dev->flags |= MLX4_FLAG_SRIOV | MLX4_FLAG_MASTER; so they are never used separately. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html