Re: [PATCH V4 5/6] RDMA CM: Netlink Client

Jason Gunthorpe
2011-01-07T20:37:42Z

On Mon, Jan 03, 2011 at 05:33:53PM +0200, Nir Muchtar wrote:
> Add callbacks and data types for statistics export.
> One callback is implemented that exports all of the current devices/ids.
> Add/remove the callback to IB Netlink on init/cleanup.

I don't have any new comments from this. If Sean and Roland are OK
with it then I think it should go in.

Please do update the git commit message for this to describe the
netlink message format so others can review it easily.

I think my points from earlier do need to be addressed in future
commits though:
- We need an ifindex for RDMA devices
- QP and IB CM information needs to be exported too
- Info to make lsof work

Jason