Re: [PATCH V4 5/6] RDMA CM: Netlink Client

Jason Gunthorpe
2011-01-17T22:11:41Z

On Mon, Jan 17, 2011 at 01:59:17PM -0800, Roland Dreier wrote:
> > If comparing to all the patches that landed @ your for-next branch for
> > this merge window, this set went through the most detailed review, any
> > reason not to push them now?
>
> Jason did a great job of reviewing the netlink stuff as it evolved, but
> I didn't pay much attention and I need to learn about details of netlink
> and then really look at the code first. When the final patches arrive
> on Jan 3 and the merge window opens the next day, there's not much time
> to get non-trivial changes merged.

I also think that introducing a new user space interface that has to
remain the same forever is not to be done lightly. I'd love to also
hear from the netdev folks what they think of the schema. I think it
is sort of like sysfs, a lot of variation and opinions on what is
right..

Jason