From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
OpenFabrics General
<general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org>,
Vlad <vlad-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH] IB/ipoib: Do not turn on carrier to a non active port
Date: Thu, 17 Sep 2009 08:02:04 -0700 [thread overview]
Message-ID: <ada4or1ehsj.fsf@cisco.com> (raw)
In-Reply-To: <4AB20C6C.9090005-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org> (Moni Shoua's message of "Thu, 17 Sep 2009 13:16:12 +0300")
> + if (ib_query_port(priv->ca, priv->port, &attr) ||
> + attr.state != IB_PORT_ACTIVE) {
> + ipoib_dbg(priv, "wait with carrier until IB port is active\n");
> + if (test_bit(IPOIB_FLAG_OPER_UP, &priv->flags))
> + queue_delayed_work(ipoib_workqueue, &priv->carrier_on_task, HZ);
> + return;
> + }
This queueing delayed work to poll the port state seems a bit odd to
me... we get an event when the port changes state anyway, right? So
can't we just turn the carrier on when we get an active event?
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-17 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 10:16 [PATCH] IB/ipoib: Do not turn on carrier to a non active port Moni Shoua
[not found] ` <4AB20C6C.9090005-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2009-09-17 15:02 ` Roland Dreier [this message]
[not found] ` <ada4or1ehsj.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-21 9:28 ` Moni Shoua
2009-09-17 15:50 ` [ofa-general] " Roland Dreier
[not found] ` <adamy4td0zp.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-09-21 9:34 ` Moni Shoua
[not found] ` <4AB7488E.6090700-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2009-09-21 15:45 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4or1ehsj.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org \
--cc=vlad-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox