From: Roland Dreier <rdreier@cisco.com>
To: David Dillow <dillowda@ornl.gov>
Cc: linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [RFC 8/8] IB/srp: consolidate hot-path variables into cache lines
Date: Wed, 05 Jan 2011 10:13:47 -0800 [thread overview]
Message-ID: <ada62u3fcbo.fsf@cisco.com> (raw)
In-Reply-To: <1293139893-11678-9-git-send-email-dillowda@ornl.gov> (David Dillow's message of "Thu, 23 Dec 2010 16:31:33 -0500")
Oh, I did have one minor comment I forgot about:
> + struct ib_cq *send_cq ____cacheline_aligned;
This could actually be ____cacheline_aligned_in_smp I think, not that it
matters at all in practice (although maybe someone will build a 1-core
embedded initiator on a memory-constrained system someday??)
- R.
prev parent reply other threads:[~2011-01-05 18:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 21:31 [RFC 0/8] IB/srp: scaling and bug fixes for 2.6.38 David Dillow
[not found] ` <1293139893-11678-1-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2010-12-23 21:31 ` [RFC 1/8] IB/srp: allow task management without a previous request David Dillow
[not found] ` <1293139893-11678-2-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2010-12-27 15:01 ` Bart Van Assche
[not found] ` <AANLkTi=sUbRP=Cg74DhXMRuhMRPMcW=JG-GsbuSd-gJ0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-27 17:31 ` David Dillow
2010-12-23 21:31 ` [RFC 2/8] IB/srp: consolidate state change code David Dillow
[not found] ` <1293139893-11678-3-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2010-12-27 15:12 ` Bart Van Assche
[not found] ` <AANLkTimE83r3EKcDwOat3Q_5=gzmCjB9A0vhs11r=hMU-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-27 17:33 ` David Dillow
2010-12-23 21:31 ` [RFC 3/8] IB/srp: allow lockless work posting David Dillow
[not found] ` <1293139893-11678-4-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2010-12-27 15:37 ` Bart Van Assche
[not found] ` <AANLkTikWXFRuP1EjtchrVvMRTLWEmanUO2OFqC4meLEZ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-27 17:39 ` David Dillow
2010-12-23 21:31 ` [RFC 4/8] IB/srp: don't move active requests to their own list David Dillow
[not found] ` <1293139893-11678-5-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2010-12-27 15:50 ` Bart Van Assche
[not found] ` <AANLkTinuOD919iV+ixcWhZpSkJP1QP=+OyphzVSq4_aO-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-12-27 17:46 ` David Dillow
2010-12-23 21:31 ` [RFC 5/8] IB/srp: reduce local coverage for command submission and EH David Dillow
[not found] ` <1293139893-11678-6-git-send-email-dillowda-1Heg1YXhbW8@public.gmane.org>
2011-01-02 17:16 ` Bart Van Assche
[not found] ` <AANLkTi=pRdoMWw4ZNy4JK9CoNGB=wyrThTNuDH+LUW0Y-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-03 8:45 ` David Dillow
2010-12-23 21:31 ` [RFC 6/8] IB/srp: reduce lock coverage of command completion David Dillow
2011-01-02 17:27 ` Bart Van Assche
[not found] ` <AANLkTikBkdn6XWgJELaBBFi1ZHen+UwQuumDn+yEPDPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-03 8:44 ` David Dillow
2010-12-23 21:31 ` [RFC 7/8] IB/srp: stop sharing the host lock with SCSI David Dillow
2010-12-27 17:49 ` David Dillow
2010-12-27 17:56 ` Boaz Harrosh
[not found] ` <4D18D355.30308-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2010-12-27 18:01 ` David Dillow
[not found] ` <1293472913.2896.36.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2010-12-27 18:47 ` Boaz Harrosh
[not found] ` <4D18DF4D.6010607-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2010-12-27 19:52 ` Dave Dillow
2010-12-28 17:38 ` Bart Van Assche
2010-12-23 21:31 ` [RFC 8/8] IB/srp: consolidate hot-path variables into cache lines David Dillow
2011-01-05 18:13 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada62u3fcbo.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=bvanassche@acm.org \
--cc=dillowda@ornl.gov \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox