Re: [PATCH v2] RDMA/CMA: fix iWARP adapter TCP port space usage

Jason Gunthorpe
2010-06-11T22:55:26Z

On Fri, Jun 11, 2010 at 03:47:55PM -0700, Hefty, Sean wrote:
> > What exactly is the end-user harm anyhow? Everything works 100%
> > correctly without this patch, and your arguments all revolved around
> > diagnostic capability..
>
> OFED includes this patch, which was picked up by the distros. I'm
> not sure iWarp customers are running without it.

Sigh. That's unconscionable. :(

> > It is a known weakness that the RDMA stack has crappy visibility. That
> > has been talked about before. If you want better visibility then fix
> > that by adding netlink stuff to dump out all the QP states, PDs, etc,
> > similar to what TCP does.
>
> This is a separate topic from what the patch is trying to address.

It isn't if that is all the patch is trying to address...

Jason