From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv10 12/12] mlx4: Add vlan support to IBoE
Date: Fri, 22 Oct 2010 14:25:11 -0700 [thread overview]
Message-ID: <ada7hh9x6mg.fsf@cisco.com> (raw)
In-Reply-To: <20100826141922.GM8795@mtldesk30> (Eli Cohen's message of "Thu, 26 Aug 2010 17:19:22 +0300")
> @@ -1801,6 +1831,11 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
> ctrl->owner_opcode = mlx4_ib_opcode[wr->opcode] |
> (ind & qp->sq.wqe_cnt ? cpu_to_be32(1 << 31) : 0) | blh;
>
> + if (vlan < 0x1000) {
> + ctrl->ins_vlan = 1 << 6;
> + ctrl->vlan_tag = vlan;
> + }
Looks like a bug here -- vlan is __be16 and holds the vlan tag in
network order. So this should be a test of be16_to_cpu(vlan) < 0x1000, right?
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-22 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 14:19 [PATCHv10 12/12] mlx4: Add vlan support to IBoE Eli Cohen
2010-10-22 21:25 ` Roland Dreier [this message]
[not found] ` <ada7hh9x6mg.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-24 7:10 ` Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7hh9x6mg.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox