From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCHv10 12/12] mlx4: Add vlan support to IBoE Date: Fri, 22 Oct 2010 14:25:11 -0700 Message-ID: References: <20100826141922.GM8795@mtldesk30> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20100826141922.GM8795@mtldesk30> (Eli Cohen's message of "Thu, 26 Aug 2010 17:19:22 +0300") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eli Cohen Cc: RDMA list List-Id: linux-rdma@vger.kernel.org > @@ -1801,6 +1831,11 @@ int mlx4_ib_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, > ctrl->owner_opcode = mlx4_ib_opcode[wr->opcode] | > (ind & qp->sq.wqe_cnt ? cpu_to_be32(1 << 31) : 0) | blh; > > + if (vlan < 0x1000) { > + ctrl->ins_vlan = 1 << 6; > + ctrl->vlan_tag = vlan; > + } Looks like a bug here -- vlan is __be16 and holds the vlan tag in network order. So this should be a test of be16_to_cpu(vlan) < 0x1000, right? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html