From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jack Morgenstein <jackm-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH] IB/mlx4: fix post_recv wq overflow check
Date: Tue, 19 Jan 2010 08:13:35 -0800 [thread overview]
Message-ID: <ada8wbugjio.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4B55D441.5050000-smomgflXvOZWk0Htik3J/w@public.gmane.org> (Or Gerlitz's message of "Tue, 19 Jan 2010 17:48:17 +0200")
> mmm, why is that common? typically there's a higher layer to which the
> IB ULP advertises some sort of maximal number of credits (e.g in the
> SCSI case, iser and srp specify the maximal number of commands in the
> scsi host template) or the ULP informs a higher layer that no more
> sends can be done (e.g IPoIB calling netif_stop_queue once it sense
> that the QP filled, etc).
bugs in the ULP. And it seems to be a common kind of bug.
In other words this check catches common bugs and makes them a gazillion
times easier to find and fix. So unless the performance impact is
extreme, I'm inclined to leave it.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-01-19 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 15:28 [PATCH] IB/mlx4: fix post_recv wq overflow check Or Gerlitz
[not found] ` <Pine.LNX.4.64.0912231727040.19295-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-01-06 20:51 ` Roland Dreier
[not found] ` <adapr5nt0rc.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-07 7:46 ` Or Gerlitz
[not found] ` <4B45913C.10405-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-01-07 7:53 ` Roland Dreier
[not found] ` <adaocl6qrjc.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-07 9:01 ` Or Gerlitz
[not found] ` <4B45A2E5.2070301-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-01-11 17:08 ` Roland Dreier
[not found] ` <adamy0kpo1m.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-19 15:48 ` Or Gerlitz
[not found] ` <4B55D441.5050000-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-01-19 16:13 ` Roland Dreier [this message]
[not found] ` <ada8wbugjio.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-20 15:47 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada8wbugjio.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=jackm-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox