Merge process for OFED patches

Merge process for OFED patches

[Bart Van Assche]

Hello Roland,

I noticed that there are seven SRP patches (bug fixes) present in OFED
1.4.1 that are not present in mainstream Linux kernels up to and
including version 2.6.30. Do you know whether it is documented
anywhere which process is followed for merging such patches in the
mainstream Linux kernel ?

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[ofa-general] Re: Merge process for OFED patches

[Bart Van Assche]

On Wed, Sep 16, 2009 at 2:44 PM, Bart Van Assche
<bart.vanassche@gmail.com> wrote:
> I noticed that there are six SRP patches (bug fixes) present in OFED
> 1.4.1 that are not present in mainstream Linux kernels up to and
> including version 2.6.30. Do you know whether it is documented
> anywhere which process is followed for merging such patches in the
> mainstream Linux kernel ?

By the way, these are the SRP patches included in OFED 1.4.1:
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_1_recreate_at_reconnect.patch
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_2_disconnect_without_wait.patch
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_3_reset_req_with_status.patch
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_4_dev_loss_tmo.patch
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_5_async_event_handler.patch
* ofa_kernel-1.4.1/kernel_patches/fixes/srp_6_target_in_out_of_fabric.patch

Bart.

[ofa-general] Re: Merge process for OFED patches

[Roland Dreier]

 > I noticed that there are seven SRP patches (bug fixes) present in OFED
 > 1.4.1 that are not present in mainstream Linux kernels up to and
 > including version 2.6.30. Do you know whether it is documented
 > anywhere which process is followed for merging such patches in the
 > mainstream Linux kernel ?

Documentation/SubmittingPatches?

Seriously, someone has to send the patches for them to get applied.

Re: Merge process for OFED patches

[Bart Van Assche]

On Wed, Sep 16, 2009 at 4:21 PM, Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> wrote:
>  > I noticed that there are seven SRP patches (bug fixes) present in OFED
>  > 1.4.1 that are not present in mainstream Linux kernels up to and
>  > including version 2.6.30. Do you know whether it is documented
>  > anywhere which process is followed for merging such patches in the
>  > mainstream Linux kernel ?
>
> Documentation/SubmittingPatches?
>
> Seriously, someone has to send the patches for them to get applied.

This should be done by the original patch author.

I would like to contact the author of the fourth patch. But
unfortunately I could not find any author information in that patch.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Merge process for OFED patches

[Or Gerlitz]

Bart Van Assche wrote:
> I would like to contact the author of the fourth patch. But unfortunately I could not find any author information in that patch.
yes, non signed and  unreviewed patches is a common practice of ofed, 
does this create legal issues? maybe that would be the way to stop this?

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Merge process for OFED patches

[Tung, Chien Tin]

>I would like to contact the author of the fourth patch. But
>unfortunately I could not find any author information in that patch.

Here is the info:

git log kernel_patches/fixes/srp_4_dev_loss_tmo.patch



commit c97ac3a3c509b6fd1fd511e44e81699c21704629
Author: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Tue Dec 9 10:34:38 2008 +0200

    SRP: Fixed the following issue:
    https://bugs.openfabrics.org/show_bug.cgi?id=1395

    Signed-off-by: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

commit 304c1ab9f7256f9673394e5b579c196055804f48
Author: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Thu Nov 27 11:13:03 2008 +0200

    SRP: Fixed the following issues:
    https://bugs.openfabrics.org/show_bug.cgi?id=1377
    https://bugs.openfabrics.org/show_bug.cgi?id=1395

    Signed-off-by: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

commit 245a9d91612a1fd3ada1703dea0bb49af379f457
Author: John Gregor <john.gregor-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Date:   Mon Sep 15 17:49:27 2008 -0700

    Refreshed all "fixes" patches

    Did a "quilt refresh" on all of the patches under kernel_patches/fixes.
    This has several effects:
    1. It regularizes the style of all the patches.
    2. It resets all the line numbers and contexts.
    3. It gets rid of the whitespace problems that required 'patch -l'.
    4. It allows stacked-git to use the patches.

    The flags I used on refresh were:
        --no-timestamps
        --diffstat
        --sort
        --strip-trailing-whitespace

    I've confirmed that the resulting tree is identical (with the exception
    of the trailing whitespace removal).

    Signed-off-by: John Gregor <john.gregor-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>

commit e79bfe1ad72c06d19a12a3bb9ca856f6509e0109
Author: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Sun Jun 15 15:08:10 2008 +0300

    SRP: Added backport patches for kernels <= 2.6.25.

    Signed-off-by: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>


Chien

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Merge process for OFED patches

[Bart Van Assche]

On Wed, Sep 16, 2009 at 4:46 PM, Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org> wrote:
>
> Bart Van Assche wrote:
>>
>> I would like to contact the author of the fourth patch. But unfortunately I could not find any author information in that patch.
>
> yes, non signed and  unreviewed patches is a common practice of ofed, does this create legal issues? maybe that would be the way to stop this?

The reason I was looking for a patch description and patch author is
that I would like to know why a certain message was generated by the
OFED 1.4.1 SRP initiator. A description in the patch or an e-mail
address of the patch author would have helped me to find this out.

By the way, after I sent the e-mail at the start of this thread I have
found this information via a web search.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html