From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: "Håkon Bugge" <Haakon.Bugge-UdXhSnd/wVw@public.gmane.org>
Cc: vlad-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3 0/2] Add support for enhanced atomic operations
Date: Thu, 11 Mar 2010 10:59:13 -0800 [thread overview]
Message-ID: <adaaaueelby.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <A27E2E88-63A0-45EE-9A70-F95B2A0C25AD-U0mLk4xYmo8@public.gmane.org> ("Håkon Bugge"'s message of "Thu, 11 Mar 2010 18:29:56 +0100")
> Did you consider my input in http://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg02803.html wrt. to these enhancements?
I think we can worry about that if/when an HCA comes along that supports
global atomics for ordinary atomics but not enhanced atomics. Although
perhaps it would be cleaner to change the atomic_cap enum to:
/*
* IB_ATOMIC_NONE: no atomic capability
* IB_ATOMIC_HCA: all ops are atomic within HCA
* IB_ATOMIC_GLOB: standard ops atomic with respect to all
memory ops; masked ops atomic within HCA
* IB_ATOMIC_GLOB_MASKED: all ops atomic with respect to all
* memory ops
*/
enum ib_atomic_cap {
IB_ATOMIC_NONE,
IB_ATOMIC_HCA,
IB_ATOMIC_GLOB,
IB_ATOMIC_GLOB_MASKED
};
(with better wording for the comments)
Thoughts?
- R.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-11 18:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 15:57 [PATCH V3 0/2] Add support for enhanced atomic operations Vladimir Sokolovsky
2010-03-11 17:29 ` Håkon Bugge
[not found] ` <A27E2E88-63A0-45EE-9A70-F95B2A0C25AD-U0mLk4xYmo8@public.gmane.org>
2010-03-11 18:59 ` Roland Dreier [this message]
[not found] ` <adaaaueelby.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-03-12 9:21 ` Håkon Bugge
[not found] ` <BA082DF0-B3C6-4405-B480-F69B0193BF17-UdXhSnd/wVw@public.gmane.org>
2010-03-12 15:53 ` Roland Dreier
[not found] ` <adavdd1a64g.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-03-16 23:49 ` Roland Dreier
[not found] ` <adaeijj96a6.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-03-17 15:32 ` Vladimir Sokolovsky
[not found] ` <4BA0F623.1050606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2010-04-12 9:44 ` Vladimir Sokolovsky
[not found] ` <4BC2EB7F.20804-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2010-04-13 17:43 ` Roland Dreier
2010-03-15 7:25 ` Vladimir Sokolovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaaaueelby.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=Haakon.Bugge-UdXhSnd/wVw@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vlad-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox