From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves Date: Thu, 05 Nov 2009 07:58:12 -0800 Message-ID: References: <4AF19E69.8070605@mellanox.co.il> <15ddcffd0911041333l165ee274mfae3508a3db755e7@mail.gmail.com> <2ED289D4E09FBD4D92D911E869B97FDD0166CA59@mtlexch01.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <2ED289D4E09FBD4D92D911E869B97FDD0166CA59-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org> (Liran Liss's message of "Thu, 5 Nov 2009 15:38:18 +0200") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liran Liss Cc: Or Gerlitz , Yevgeny Petrilin , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tziporet Koren List-Id: linux-rdma@vger.kernel.org > This approach seems to be common practice now (e.g., drivers/net/igb/igb_main.c:1332). > In any case, the user can change the randomized mac. igb uses the full output of random_ether_addr(). I'd be fine with that. However setting the OUI means you only get 24 bits of randomness which makes a collision a lot more likely. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html