From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv10 08/12] mlx4: Add support for IBoE - address resolution
Date: Thu, 21 Oct 2010 14:14:11 -0700 [thread overview]
Message-ID: <adad3r38d0c.fsf@cisco.com> (raw)
In-Reply-To: <20100826141851.GI8795@mtldesk30> (Eli Cohen's message of "Thu, 26 Aug 2010 17:18:51 +0300")
> enum {
> /*
> * Largest possible UD header: send with GRH and immediate data.
> + * 4 bytes added to accommodate for eth header instead of lrh
> */
> - MLX4_IB_UD_HEADER_SIZE = 72,
> + MLX4_IB_UD_HEADER_SIZE = 76,
I don't understand this change either. As far as I can tell, a 14-byte
Ethernet header is 6 bytes longer than an 8-byte LRH, and with .1q the
18-byte header will require 10 bytes more than the LRH. So shouldn't
this value be 78 in this patch and updated to 82 in the VLAN patch?
(It probably works in practice because the allocation of sqp structs
gets rounded up enough)
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-21 21:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 14:18 [PATCHv10 08/12] mlx4: Add support for IBoE - address resolution Eli Cohen
2010-10-21 5:22 ` Roland Dreier
[not found] ` <adazku85dcf.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 7:27 ` Eli Cohen
2010-10-21 19:48 ` Roland Dreier
[not found] ` <adazku78gzz.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 22:51 ` Eli Cohen
2010-10-22 4:15 ` Roland Dreier
2010-10-21 19:57 ` Roland Dreier
[not found] ` <adavd4v8gk4.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 22:54 ` Eli Cohen
2010-10-21 21:14 ` Roland Dreier [this message]
[not found] ` <adad3r38d0c.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 21:15 ` Roland Dreier
[not found] ` <ada8w1r8cxo.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-21 23:03 ` Eli Cohen
2010-10-22 4:15 ` Roland Dreier
[not found] ` <adazku6yiag.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-10-22 12:24 ` Eli Cohen
2010-10-21 23:01 ` Eli Cohen
2010-10-22 15:59 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adad3r38d0c.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox