public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 05/10] iw_cxgb4: Add connection management functions.
Date: Mon, 26 Apr 2010 09:22:17 -0700	[thread overview]
Message-ID: <adaeii2mbeu.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4BD5A98C.8030700-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> (Steve Wise's message of "Mon, 26 Apr 2010 09:56:12 -0500")

 >  > +int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new,

 > > As far as I can see this function is not called or otherwise referenced
 > > anywhere else (except for a declaration in a header).  Can we drop it?

 > Yes.

OK, I rolled the following up into the big "merge iw_cxgb4" patch I have queued:

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index e1c1ee0..b602438 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2260,24 +2260,6 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)
 	return ret;
 }
 
-int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new,
-		     struct l2t_entry *l2t)
-{
-	struct c4iw_ep *ep = ctx;
-
-	if (ep->dst != old)
-		return 0;
-
-	PDBG("%s ep %p redirect to dst %p l2t %p\n", __func__, ep, new,
-	     l2t);
-	dst_hold(new);
-	cxgb4_l2t_release(ep->l2t);
-	ep->l2t = l2t;
-	dst_release(old);
-	ep->dst = new;
-	return 1;
-}
-
 /*
  * All the CM events are handled on a work queue to have a safe context.
  */

-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-04-26 16:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16 18:29 [PATCH v3 00/10] iw_cxgb4 driver submission Steve Wise
     [not found] ` <20100416182924.22495.59421.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-16 18:29   ` [PATCH v3 01/10] iw_cxgb4: Makefile and Kconfig files and changes Steve Wise
2010-04-16 18:29   ` [PATCH v3 02/10] iw_cxgb4: Add driver, fw, and hw headers Steve Wise
2010-04-16 18:29   ` [PATCH v3 03/10] iw_cxgb4: Add module and low level device interface functions Steve Wise
2010-04-16 18:29   ` [PATCH v3 04/10] iw_cxgb4: Add rdma provider " Steve Wise
2010-04-16 18:29   ` [PATCH v3 05/10] iw_cxgb4: Add connection management functions Steve Wise
     [not found]     ` <20100416182951.22495.60351.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-21 22:41       ` Roland Dreier
     [not found]         ` <adask6oo2d4.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-04-26 14:56           ` Steve Wise
     [not found]             ` <4BD5A98C.8030700-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-04-26 16:22               ` Roland Dreier [this message]
2010-04-16 18:29   ` [PATCH v3 06/10] iw_cxgb4: Add memory " Steve Wise
2010-04-16 18:30   ` [PATCH v3 07/10] iw_cxgb4: Add CQ " Steve Wise
2010-04-16 18:30   ` [PATCH v3 08/10] iw_cxgb4: Add QP " Steve Wise
2010-04-16 18:30   ` [PATCH v3 09/10] iw_cxgb4: Add event " Steve Wise
2010-04-16 18:30   ` [PATCH v3 10/10] iw_cxgb4: Add id and hw resource " Steve Wise
2010-04-16 18:41   ` [PATCH v3 00/10] iw_cxgb4 driver submission Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaeii2mbeu.fsf@roland-alpha.cisco.com \
    --to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox