From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Yevgeny Petrilin <yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mlx4_core: num reserved eqs presented as log and actual
Date: Fri, 19 Feb 2010 11:10:41 -0800 [thread overview]
Message-ID: <adaeikh82j2.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4B790CAD.2070007-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> (Yevgeny Petrilin's message of "Mon, 15 Feb 2010 10:58:21 +0200")
> Multifunctional firmware should present number of reserved EQs as
> an actual number (number of reserved eqs is not necessarily a power
> of 2).
> Older drivers treat this field as log, so when there are relatively big
> number of reserved eqs, they would fail.
> The firmware would present the number of EQs as log in a single function mode
> (which would also work for older driver versions) and as actual number (in other field)
> in multifunctional mode. The new code would check both fields.
> Fixes commit be504b0b9fbe9ba447c93ef0f5789f377102d555
I can't really follow this changelog. The (very old) ConnextX PRM I
have states that the field returned by the firmware is the actual
number, so the old driver behavior was wrong. Or was the PRM wrong?
Are you changing the firmware behavior to make that field into a log?
Is this really the best way to clean this up, having the same
information twice in two different formats?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-02-19 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 8:58 [PATCH] mlx4_core: num reserved eqs presented as log and actual Yevgeny Petrilin
[not found] ` <4B790CAD.2070007-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2010-02-19 19:10 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaeikh82j2.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox