[PATCH] infiniband: qib: Missing linux/slab.h include

[PATCH] infiniband: qib: Missing linux/slab.h include

[David Miller]

Signed-off-by: David S. Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
---

Without this I'm getting build errors with Linus's current tree.
Apologies if this is already fixed in the RDMA git tree.

diff --git a/drivers/infiniband/hw/qib/qib.h b/drivers/infiniband/hw/qib/qib.h
index 3593983..312ca9a 100644
--- a/drivers/infiniband/hw/qib/qib.h
+++ b/drivers/infiniband/hw/qib/qib.h
@@ -45,6 +45,7 @@
 #include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/scatterlist.h>
+#include <linux/slab.h>
 #include <linux/io.h>
 #include <linux/fs.h>
 #include <linux/completion.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband: qib: Missing linux/slab.h include

[Roland Dreier]

  > Without this I'm getting build errors with Linus's current tree.
  > Apologies if this is already fixed in the RDMA git tree.
  > 
  > diff --git a/drivers/infiniband/hw/qib/qib.h b/drivers/infiniband/hw/qib/qib.h
  > index 3593983..312ca9a 100644
  > --- a/drivers/infiniband/hw/qib/qib.h
  > +++ b/drivers/infiniband/hw/qib/qib.h
  > @@ -45,6 +45,7 @@
  >  #include <linux/mutex.h>
  >  #include <linux/list.h>
  >  #include <linux/scatterlist.h>
  > +#include <linux/slab.h>

No objection to adding this and I will include it for my next pull.  But
out of curiousity what arch are you seeing this on?  I'm not seeing any
problems on x86 and I haven't heard any complaints about -next so I'm
curious what the error you're seeing is.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband: qib: Missing linux/slab.h include

[David Miller]

From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Date: Thu, 05 Aug 2010 09:29:58 -0700

> No objection to adding this and I will include it for my next pull.  But
> out of curiousity what arch are you seeing this on?  I'm not seeing any
> problems on x86 and I haven't heard any complaints about -next so I'm
> curious what the error you're seeing is.

sparc64 allmodconfig
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband: qib: Missing linux/slab.h include

[Roland Dreier]

 > > No objection to adding this and I will include it for my next pull.  But
 > > out of curiousity what arch are you seeing this on?  I'm not seeing any
 > > problems on x86 and I haven't heard any complaints about -next so I'm
 > > curious what the error you're seeing is.

 > sparc64 allmodconfig

Got it.  Interestingly x86, powerpc and ia64 all include linux/slab.h
via asm/pci.h (for no very obvious reason that I can see from a quick
look at what their asm/pci.h have), which is why I missed this.

anyway, applied your patch and will pass on to Linus shortly.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html