cxgb4 missing error handling?

cxgb4 missing error handling?

[Roland Dreier]

in cm.c we have:

int c4iw_reject_cr(struct iw_cm_id *cm_id, const void *pdata, u8 pdata_len)
{
	int err;
	struct c4iw_ep *ep = to_ep(cm_id);
	PDBG("%s ep %p tid %u\n", __func__, ep, ep->hwtid);

	if (state_read(&ep->com) == DEAD) {
		c4iw_put_ep(&ep->com);
		return -ECONNRESET;
	}
	BUG_ON(state_read(&ep->com) != MPA_REQ_RCVD);
	if (mpa_rev == 0)
		abort_connection(ep, NULL, GFP_KERNEL);
	else {
		err = send_mpa_reject(ep, pdata, pdata_len);
		err = c4iw_ep_disconnect(ep, 0, GFP_KERNEL);
	}
	c4iw_put_ep(&ep->com);
	return 0;
}

latest gcc warns that the variable err is assigned to but never used --
and indeed it seems this code either should be doing something in the
failure case or not even storing the return value if it doesn't care.

Which one is it though?

 - R.
-- 
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: cxgb4 missing error handling?

[Steve Wise]

On 08/04/2010 04:17 PM, Roland Dreier wrote:
> in cm.c we have:
>
> int c4iw_reject_cr(struct iw_cm_id *cm_id, const void *pdata, u8 pdata_len)
> {
> 	int err;
> 	struct c4iw_ep *ep = to_ep(cm_id);
> 	PDBG("%s ep %p tid %u\n", __func__, ep, ep->hwtid);
>
> 	if (state_read(&ep->com) == DEAD) {
> 		c4iw_put_ep(&ep->com);
> 		return -ECONNRESET;
> 	}
> 	BUG_ON(state_read(&ep->com) != MPA_REQ_RCVD);
> 	if (mpa_rev == 0)
> 		abort_connection(ep, NULL, GFP_KERNEL);
> 	else {
> 		err = send_mpa_reject(ep, pdata, pdata_len);
> 		err = c4iw_ep_disconnect(ep, 0, GFP_KERNEL);
> 	}
> 	c4iw_put_ep(&ep->com);
> 	return 0;
> }
>
> latest gcc warns that the variable err is assigned to but never used --
> and indeed it seems this code either should be doing something in the
> failure case or not even storing the return value if it doesn't care.
>
> Which one is it though?
>
>   - R.
>    

Good question. :)

I think we should get rid of 'err' altogether and ignore return values 
from send_mpa_reject() and c4iw_ep_disconnect().




--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html