From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 05/10] iw_cxgb4: Add connection management functions.
Date: Wed, 07 Apr 2010 14:32:15 -0700 [thread overview]
Message-ID: <adaljcz0x0g.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100402192413.14117.56138.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org> (Steve Wise's message of "Fri, 02 Apr 2010 14:24:14 -0500")
> +int peer2peer = 0;
> +module_param(peer2peer, int, 0644);
> +MODULE_PARM_DESC(peer2peer, "Support peer2peer ULPs (default=0)");
If you build iw_cxgb3 and iw_cxgb4 into the kernel, the peer2peer symbol
names clash. (Same problem occurs if you try to load cxgb3 and cxgb4
modules at the same time, I think). We can fix it here in cxgb4 by just
making peer2peer static (and deleting the extern declaration).
However peer2peer is not that great of a name for a global symbol; might
be good to add a patch to cxgb3 to rename peer2peer to something like
iwch_peer2peer and using module_param_named()...
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-07 21:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 19:23 [PATCH 00/10] iw_cxgb4 driver submission Steve Wise
[not found] ` <20100402192346.14117.92767.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-02 19:23 ` [PATCH 01/10] iw_cxgb4: Makefile and Kconfig files and changes Steve Wise
2010-04-02 19:23 ` [PATCH 02/10] iw_cxgb4: Add driver, fw, and hw headers Steve Wise
[not found] ` <20100402192357.14117.39150.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-07 21:33 ` Roland Dreier
[not found] ` <adahbnn0wxl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-04-07 21:50 ` Steve Wise
2010-04-07 22:32 ` Steve Wise
[not found] ` <4BBD0807.10001-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-04-07 22:37 ` Roland Dreier
2010-04-02 19:24 ` [PATCH 03/10] iw_cxgb4: Add module and low level device interface functions Steve Wise
2010-04-02 19:24 ` [PATCH 04/10] iw_cxgb4: Add rdma provider " Steve Wise
2010-04-02 19:24 ` [PATCH 05/10] iw_cxgb4: Add connection management functions Steve Wise
[not found] ` <20100402192413.14117.56138.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-07 21:32 ` Roland Dreier [this message]
[not found] ` <adaljcz0x0g.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-04-07 21:49 ` Steve Wise
[not found] ` <4BBCFDF9.70306-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-04-07 21:55 ` Roland Dreier
2010-04-07 21:36 ` Roland Dreier
2010-04-07 21:37 ` Roland Dreier
2010-04-02 19:24 ` [PATCH 06/10] iw_cxgb4: Add memory " Steve Wise
[not found] ` <20100402192419.14117.40759.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-04-07 21:40 ` Roland Dreier
2010-04-02 19:24 ` [PATCH 07/10] iw_cxgb4: Add CQ " Steve Wise
2010-04-02 19:24 ` [PATCH 08/10] iw_cxgb4: Add QP " Steve Wise
2010-04-02 19:24 ` [PATCH 09/10] iw_cxgb4: Add event " Steve Wise
2010-04-02 19:24 ` [PATCH 10/10] iw_cxgb4: Add id and hw resource " Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaljcz0x0g.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox