Re: [PATCH v2] RDMA/CMA: fix iWARP adapter TCP port space usage

Jason Gunthorpe
2010-06-11T22:41:27Z

On Fri, Jun 11, 2010 at 03:08:20PM -0700, Roland Dreier wrote:

> If Dave Miller says this is an unacceptable thing to merge, then I'm not
> going to merge it over his explicit and unequivocal NAK. Trying sneak
> this in by hiding this patch on linux-rdma without cc-ing netdev is the
> wrong approach... the right approach is to get the hordes of users being
> hurt by this issue (if there are such hordes), make a big stink, and
> force a solution that everyone agrees on.

Right..

What exactly is the end-user harm anyhow? Everything works 100%
correctly without this patch, and your arguments all revolved around
diagnostic capability..

It is a known weakness that the RDMA stack has crappy visibility. That
has been talked about before. If you want better visibility then fix
that by adding netlink stuff to dump out all the QP states, PDs, etc,
similar to what TCP does.

Jason