From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Or Gerlitz <ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jack Morgenstein <jackm-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH] IB/mlx4: fix post_recv wq overflow check
Date: Mon, 11 Jan 2010 09:08:21 -0800 [thread overview]
Message-ID: <adamy0kpo1m.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4B45A2E5.2070301-smomgflXvOZWk0Htik3J/w@public.gmane.org> (Or Gerlitz's message of "Thu, 07 Jan 2010 11:01:25 +0200")
> I wonder if the overflow check could be removed all together and be
> left to the ULP (kernel is trusted environment...) is there any risk
> in doing so? this way the WR posting code will not experience
> contention with the poll WC code on the CQ lock.
We could do that I guess if it's a really big performance gain. I do
think it is quite common to see this WQ overflow check trigger, even for
kernel code, and so we would have to be sure the performance gain is
worth making these bugs much harder to find and fix.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-01-11 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 15:28 [PATCH] IB/mlx4: fix post_recv wq overflow check Or Gerlitz
[not found] ` <Pine.LNX.4.64.0912231727040.19295-aDiYczhfhVLdX2U7gxhm1tBPR1lH4CV8@public.gmane.org>
2010-01-06 20:51 ` Roland Dreier
[not found] ` <adapr5nt0rc.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-07 7:46 ` Or Gerlitz
[not found] ` <4B45913C.10405-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
2010-01-07 7:53 ` Roland Dreier
[not found] ` <adaocl6qrjc.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-07 9:01 ` Or Gerlitz
[not found] ` <4B45A2E5.2070301-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-01-11 17:08 ` Roland Dreier [this message]
[not found] ` <adamy0kpo1m.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-19 15:48 ` Or Gerlitz
[not found] ` <4B55D441.5050000-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2010-01-19 16:13 ` Roland Dreier
[not found] ` <ada8wbugjio.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-20 15:47 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adamy0kpo1m.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=jackm-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox