Re: [PATCH 02/53] IB/qib: Add Makefile

Roland Dreier
2009-11-20T00:05:53Z

> +ccflags-y += -DQIB_KERN_TYPE=0 -DQIB_IDSTR='"QLogic kernel.org driver"'

Do we really need to put this in the Makefile? Why can't this be done
in some header file? What the heck is the KERN_TYPE anyway?

> +ib_qib-y := \
> + qib_cq.o \
> + qib_diag.o \
> + qib_dma.o \
> + qib_driver.o \
> + qib_eeprom.o \
> + qib_file_ops.o \
> + qib_fs.o \
> + qib_init.o \
> + qib_intr.o \
> + qib_keys.o \

I think the convention is to do this with multiple files per line, ie

ib_qib-y := qip_cq.o qib_diag.o qib_dma.o ... \
...

> +ib_qib-$(CONFIG_PCI_MSI) += qib_iba6120.o

Seems you put the 6120 in the module device table even if PCI_MSI isn't
set... does the driver build without MSI enabled?

And are you dropping 6110 support (I see no HT_IRQ stuff)? So do we
need to keep ipath around for that?

- R.