Re: [PATCH 02/53] IB/qib: Add Makefile

Dave Olson
2009-11-20T01:07:45Z

On Thu, 19 Nov 2009, Roland Dreier wrote:

|
| > +ccflags-y += -DQIB_KERN_TYPE=0 -DQIB_IDSTR='"QLogic kernel.org driver"'
|
| Do we really need to put this in the Makefile? Why can't this be done
| in some header file? What the heck is the KERN_TYPE anyway?

A way of distinguishing qlogic-built drivers from elsewhere. We'll fix
this; it shouldn't be needed in the upstream driver.

|
| I think the convention is to do this with multiple files per line, ie
|
| ib_qib-y := qip_cq.o qib_diag.o qib_dma.o ... \

Last time we did that, we got asked to change it to one per line. If
conventions have changed, no problem.

| > +ib_qib-$(CONFIG_PCI_MSI) += qib_iba6120.o
|
| Seems you put the 6120 in the module device table even if PCI_MSI isn't
| set... does the driver build without MSI enabled?

Yes. It just doesn't work well. It works well enough to tell people
what the problem is, which is what we wanted.

| And are you dropping 6110 support (I see no HT_IRQ stuff)? So do we
| need to keep ipath around for that?

6110 is out of this driver, and people (customers) are aware that support has
been dropped. The current (non-verbs) userland software won't work on those
boards any longer, and customers were using them primarily for non-verbs
MPI.

The ipath driver has some significant problems with verbs, and those
problems have been fixed based on the significant restructuring and
rewrites in the ib_qib driver, so it's unlikely that any customer would
want to continue to use the ib_ipath driver in any case.

It seems to me that people who want the ib_ipath driver are likely to
use it only on older kernels where it was known to work OK, in any case.
Testing on ib_ipath (by QLogic, at least) stopped with the 2.6.24 kernel.

Dave Olson
dave.olson-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org