Re: [PATCH 39/53] IB/qib: Add qib_trace.c

Roland Dreier
2009-11-20T00:14:22Z

Seems all this infrastructure could be profitably ripped out and
replaced with the more powerful and flexible ftrace events stuff...

> +#ifndef ATOMIC_NOTIFIER_INIT
> +/*
> + * Some backports don't have this, so define here for now.
> + * We may not want to keep this for upstream. If we do, we'll
> + * do this via the backports at that time.
> + */
> +#define atomic_notifier_chain_register notifier_chain_register
> +#define atomic_notifier_chain_unregister notifier_chain_unregister
> +#endif

Doesn't seem like this was meant to go into the upstream submission?
Seems like it would be worth going over the patches again and cleaning
up everything that is solely for compatibility with old kernels.

I don't think random PCI device drivers hooking into the panic notifier
chain is really a good idea, so probably ripping this out for now is the
best thing to do.

- R.