public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org,
	Ishai Rabinovitz <ishai-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [ewg] Mellanox target workaround in SRP
Date: Mon, 10 Jan 2011 10:49:09 -0800	[thread overview]
Message-ID: <adapqs48uhm.fsf@cisco.com> (raw)
In-Reply-To: <4D2B4E13.6070903-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> (Vu Pham's message of "Mon, 10 Jan 2011 10:21:07 -0800")

 > I think that the patch is specific for srp initiator using Mellanox
 > FMR. It tried to avoid indirect desc with Mellanox FMR having
 > first-byte-offset != 0.  Since the low level implementation of
 > mlx4/mthca_map_phys_fmr() did not create + setup MPT for FMR with
 > first_byte_offset != 0. The corruption can happen with any target.

I don't think this could be right -- right now the workaround only
triggers if the target has a Mellanox OUI, so if what you say is true,
presumably everyone who is using the SRP initiator with mlx4 would be
seeing this problem.

Also, the SRP initiator code that uses ib_fmr_pool_map_phys does not
pass in any non-aligned addresses -- it doesn't try to use any first
byte offset, it just uses the virtual address it passes to the target to
handle the offset.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-01-10 18:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 22:35 Mellanox target workaround in SRP David Dillow
     [not found] ` <1294439717.6219.54.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2011-01-08  4:05   ` Roland Dreier
     [not found]     ` <adaipy09h0i.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-08 18:13       ` David Dillow
     [not found]         ` <1294510396.7914.82.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-10 18:21           ` Vu Pham
     [not found]             ` <4D2B4E13.6070903-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-10 18:49               ` Roland Dreier [this message]
     [not found]                 ` <adapqs48uhm.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-10 19:05                   ` [ewg] " David Dillow
2011-01-10 19:49                   ` Vu Pham
2011-01-10 19:02               ` David Dillow
     [not found]                 ` <1294686163.3038.12.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-10 19:58                   ` Vu Pham
     [not found]                     ` <4D2B64CA.6040609-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-17  4:50                       ` David Dillow
     [not found]                         ` <1295239821.3051.1.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-18 19:53                           ` Vu Pham
     [not found]                             ` <4D35EF9C.3050609-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-18 20:05                               ` David Dillow
2011-01-10 18:51   ` Roland Dreier
     [not found]     ` <adaipxw8ue6.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-12 13:40       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adapqs48uhm.fsf@cisco.com \
    --to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=dillowda-1Heg1YXhbW8@public.gmane.org \
    --cc=ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
    --cc=ishai-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox