From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Eli Cohen <eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing
Date: Thu, 26 Aug 2010 23:17:11 -0700 [thread overview]
Message-ID: <adar5hk37h4.fsf@cisco.com> (raw)
In-Reply-To: <20100826141823.GF8795@mtldesk30> (Eli Cohen's message of "Thu, 26 Aug 2010 17:18:23 +0300")
In the future, please don't have patches that break compilation. If you
change an API, then change all users of that API in the same patch.
It's really annoying for someone who is trying to bisect something
(possibly something completely unrelated) to land at a point in history
that doesn't even build.
So if there's another spin of this patchset, please fold all the "adapt
to new API" patches into the main "change API" patches. You don't have
to resend just for that though, I can handle it if I apply these.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-08-27 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 14:18 [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing Eli Cohen
2010-08-27 6:17 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar5hk37h4.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=eli-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox