public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing
@ 2010-08-26 14:18 Eli Cohen
  2010-08-27  6:17 ` Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Cohen @ 2010-08-26 14:18 UTC (permalink / raw)
  To: Roland Dreier; +Cc: RDMA list

This is done to synchronize mthca with the API changes.

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
---
 drivers/infiniband/hw/mthca/mthca_qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index d2d172e..1a1c55f 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -1493,7 +1493,7 @@ static int build_mlx_header(struct mthca_dev *dev, struct mthca_sqp *sqp,
 	int err;
 	u16 pkey;
 
-	ib_ud_header_init(256, /* assume a MAD */
+	ib_ud_header_init(256, /* assume a MAD */ 1, 0,
 			  mthca_ah_grh_present(to_mah(wr->wr.ud.ah)), 0,
 			  &sqp->ud_header);
 
-- 
1.7.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing
  2010-08-26 14:18 [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing Eli Cohen
@ 2010-08-27  6:17 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2010-08-27  6:17 UTC (permalink / raw)
  To: Eli Cohen; +Cc: RDMA list

In the future, please don't have patches that break compilation.  If you
change an API, then change all users of that API in the same patch.
It's really annoying for someone who is trying to bisect something
(possibly something completely unrelated) to land at a point in history
that doesn't even build.

So if there's another spin of this patchset, please fold all the "adapt
to new API" patches into the main "change API" patches.  You don't have
to resend just for that though, I can handle it if I apply these.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-27  6:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 14:18 [PATCHv10 05/12] mthca: Adapt to API changes in the core for UD packing Eli Cohen
2010-08-27  6:17 ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox