From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Oren Duer <oren-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Linux RDMA <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
OpenFabrics EWG
<ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org>
Subject: Re: [PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device
Date: Mon, 09 Aug 2010 09:10:26 -0700 [thread overview]
Message-ID: <adar5i7zs0d.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4C5C9170.20706-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> (Vu Pham's message of "Fri, 06 Aug 2010 15:49:20 -0700")
Unfortunately it will probably be a while before I can look at this in
any detail, but here are some obvious things to fix:
- The actual FC/SCSI driver will need to be reviewed on
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org of course; so please CC that list.
- The ordering/split of patches seems off; in particular I notice that
the patch that adds the new drivers into the build system comes
before the patch that actually adds the new drivers, which is
obviously wrong (since the kernel will be broken if we apply patch
9/10 but not 10/10).
- None of the patch subjects contain a subject that says what part of
the kernel they touch. For example, instead of
"[PATCH 01/10] pre-reserve MPTs for FC"
please write:
"[PATCH 01/10] mlx4_core: Pre-reserve MPTs for FC"
otherwise I waste time having to fix it up by hand. (And also if you
want to do things exactly write, please capitalize the subject but do
not put in a final '.' But I usually do not complain about that
level of detail)
- Every patch seems to have the changelog and diffstat twice. Please
fix (and include a "---" between the changelog and diffstat). If you
prepare a clean git tree, then git format-patch will get everything
exactly correct.
- There seem to be a lot of whitespace and other formatting problems.
Please run patches through checkpatch.pl and fix any real problems
that it finds (0 warnings are not necessary since some warnings are
false positives; but I suspect for these patches most won't be).
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-08-09 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 22:49 [PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device Vu Pham
[not found] ` <4C5C9170.20706-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2010-08-09 16:10 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar5i7zs0d.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oren-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox