From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH 01/25 v2] mlx4_core: identify function as pf or vf Date: Mon, 25 Jan 2010 11:20:04 -0800 Message-ID: References: <4AF3930E.90904@mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <4AF3930E.90904-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org> (Yevgeny Petrilin's message of "Fri, 06 Nov 2009 05:07:58 +0200") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yevgeny Petrilin Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org, tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org List-Id: linux-rdma@vger.kernel.org > enum { > MLX4_FLAG_MSI_X = 1 << 0, > MLX4_FLAG_OLD_PORT_CMDS = 1 << 1, > + MLX4_FLAG_MASTER = 1 << 2, > + MLX4_FLAG_SLAVE = 1 << 3, > + MLX4_FLAG_SRIOV = 1 << 4, > }; I'm a bit confused by these flags. As far as I can tell, the SRIOV flag will be set if and only if MASTER is set too... so in other words we might as well just have the MASTER and SLAVE flags and not have the SRIOV flag at all. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html