From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH v3 05/10] iw_cxgb4: Add connection management functions. Date: Wed, 21 Apr 2010 15:41:11 -0700 Message-ID: References: <20100416182924.22495.59421.stgit@build.ogc.int> <20100416182951.22495.60351.stgit@build.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20100416182951.22495.60351.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org> (Steve Wise's message of "Fri, 16 Apr 2010 13:29:51 -0500") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Wise Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Thanks, all this looks pretty clean and small so I added it (as one big patch). One tiny issue that we can fix with a follow-up patch: > +int c4iw_ep_redirect(void *ctx, struct dst_entry *old, struct dst_entry *new, > + struct l2t_entry *l2t) > +{ > + struct c4iw_ep *ep = ctx; > + > + if (ep->dst != old) > + return 0; > + > + PDBG("%s ep %p redirect to dst %p l2t %p\n", __func__, ep, new, > + l2t); > + dst_hold(new); > + cxgb4_l2t_release(ep->l2t); > + ep->l2t = l2t; > + dst_release(old); > + ep->dst = new; > + return 1; > +} As far as I can see this function is not called or otherwise referenced anywhere else (except for a declaration in a header). Can we drop it? -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html