From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock <hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org>
Cc: sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rdma_cm.h: Fix SCTP protocol ID
Date: Wed, 13 Jan 2010 13:04:08 -0800 [thread overview]
Message-ID: <adaska9n2d3.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100113192454.GA17655-Wuw85uim5zDR7s880joybQ@public.gmane.org> (Hal Rosenstock's message of "Wed, 13 Jan 2010 14:24:54 -0500")
> - RDMA_PS_SCTP = 0x0183
> + RDMA_PS_SCTP = 0x0184
The old wrong value has been there since we first merged this. So
changing it means anything using this in userspace would be broken. But
is PS_SCTP exported to userspace? And as far as I can tell PS_SCTP is
not implemented (this line is the only reference to RDMA_PS_SCTP in the
whole kernel). So would it make more sense to delete this enum value entirely?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-01-13 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 19:24 [PATCH] rdma_cm.h: Fix SCTP protocol ID Hal Rosenstock
[not found] ` <20100113192454.GA17655-Wuw85uim5zDR7s880joybQ@public.gmane.org>
2010-01-13 19:51 ` Sean Hefty
2010-01-13 21:04 ` Roland Dreier [this message]
[not found] ` <adaska9n2d3.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-13 21:11 ` Sean Hefty
[not found] ` <7E10F17E68C24836BE68F8F22B64862B-Zpru7NauK7drdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2010-01-13 21:21 ` Roland Dreier
[not found] ` <adak4vln1ks.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-01-13 21:38 ` Sean Hefty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaska9n2d3.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=hnrose-Wuw85uim5zDR7s880joybQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox