[PATCH] rdma_cm.h: Fix SCTP protocol ID

[PATCH] rdma_cm.h: Fix SCTP protocol ID

[Hal Rosenstock]

Should be 132 rather than 131 according to IANA IP protocol IDs

Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
diff --git a/include/rdma/rdma_cm.h b/include/rdma/rdma_cm.h
index c6b2962..1c5e589 100644
--- a/include/rdma/rdma_cm.h
+++ b/include/rdma/rdma_cm.h
@@ -67,7 +67,7 @@ enum rdma_port_space {
 	RDMA_PS_IPOIB = 0x0002,
 	RDMA_PS_TCP   = 0x0106,
 	RDMA_PS_UDP   = 0x0111,
-	RDMA_PS_SCTP  = 0x0183
+	RDMA_PS_SCTP  = 0x0184
 };
 
 struct rdma_addr {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

[Sean Hefty]

>Should be 132 rather than 131 according to IANA IP protocol IDs
>
>Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

>---

Thanks.  I just noticed this this morning after reviewing the luster patches.
You beat me to the patch.

>diff --git a/include/rdma/rdma_cm.h b/include/rdma/rdma_cm.h
>index c6b2962..1c5e589 100644
>--- a/include/rdma/rdma_cm.h
>+++ b/include/rdma/rdma_cm.h
>@@ -67,7 +67,7 @@ enum rdma_port_space {
> 	RDMA_PS_IPOIB = 0x0002,
> 	RDMA_PS_TCP   = 0x0106,
> 	RDMA_PS_UDP   = 0x0111,
>-	RDMA_PS_SCTP  = 0x0183
>+	RDMA_PS_SCTP  = 0x0184
> };
>
> struct rdma_addr {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma_cm.h: Fix SCTP protocol ID

[Roland Dreier]

 > -	RDMA_PS_SCTP  = 0x0183
 > +	RDMA_PS_SCTP  = 0x0184

The old wrong value has been there since we first merged this.  So
changing it means anything using this in userspace would be broken.  But
is PS_SCTP exported to userspace?  And as far as I can tell PS_SCTP is
not implemented (this line is the only reference to RDMA_PS_SCTP in the
whole kernel).  So would it make more sense to delete this enum value entirely?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

[Sean Hefty]

>The old wrong value has been there since we first merged this.  So
>changing it means anything using this in userspace would be broken.  But
>is PS_SCTP exported to userspace?  And as far as I can tell PS_SCTP is
>not implemented (this line is the only reference to RDMA_PS_SCTP in the
>whole kernel).  So would it make more sense to delete this enum value entirely?

Technically, I believe it's available to userspace, though the librdmacm doesn't
define it.  I'd be surprised if anything uses it.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rdma_cm.h: Fix SCTP protocol ID

[Roland Dreier]

 > Technically, I believe it's available to userspace, though the librdmacm doesn't
 > define it.  I'd be surprised if anything uses it.

Wouldn't trying to use RDMA_PS_SCTP hit the

	default:
		return -EPROTONOSUPPORT;

case in cma_get_port()?  So one couldn't actually do anything with
RDMA_PS_SCTP?  Or is there some way to avoid binding?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

[Sean Hefty]

>Wouldn't trying to use RDMA_PS_SCTP hit the
>
>	default:
>		return -EPROTONOSUPPORT;
>
>case in cma_get_port()?  So one couldn't actually do anything with
>RDMA_PS_SCTP?  Or is there some way to avoid binding?

You're right.  There isn't any way to actually do anything with it.  All code
paths go through rdma_bind_addr.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html