From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Chien Tung <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] RDMA/nes: get and print eeprom version
Date: Wed, 09 Jun 2010 13:38:56 -0700 [thread overview]
Message-ID: <adatypckkkf.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100609201953.GA2304@CTUNG-MOBL1> (Chien Tung's message of "Wed, 9 Jun 2010 15:19:53 -0500")
Is this something that it might be better to expose via ethtool in the
firmware-version field? (You can have a string with multiple versions
of different components there, see eg get_drvinfo() in
drivers/net/cxgb3/cxgb3_main.c)
As far as I can see, in the current patch, you have eeprom_version as a
pure write-only field. So instead of dumping to the kernel log, where
it might get lost and is in any case hard to find, make it easier to
read out when someone needs it.
- R.
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-09 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 20:19 [PATCH] RDMA/nes: get and print eeprom version Chien Tung
2010-06-09 20:38 ` Roland Dreier [this message]
[not found] ` <adatypckkkf.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-06-09 21:19 ` Tung, Chien Tin
2010-07-28 22:12 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatypckkkf.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox