public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] ib/ehca: fixes for -next
@ 2010-01-27 17:00 Alexander Schmidt
  2010-01-27 17:01 ` [PATCH 1/2] ib/ehca: Do not turn off irqs in tasklet context Alexander Schmidt
  2010-01-27 17:03 ` [PATCH 2/2] ib/ehca: allow access for ib_query_qp() Alexander Schmidt
  0 siblings, 2 replies; 4+ messages in thread
From: Alexander Schmidt @ 2010-01-27 17:00 UTC (permalink / raw)
  To: Roland Dreier, Linux RDMA
  Cc: lkml, Stefan Roscher, Joachim Fenkes, Christoph Raisch,
	Hoang-Nam Nguyen, David Wilder

Hi Roland,

please apply these two patches for your -next tree.

Regards,
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ib/ehca: Do not turn off irqs in tasklet context
  2010-01-27 17:00 [PATCH 0/2] ib/ehca: fixes for -next Alexander Schmidt
@ 2010-01-27 17:01 ` Alexander Schmidt
  2010-01-27 17:03 ` [PATCH 2/2] ib/ehca: allow access for ib_query_qp() Alexander Schmidt
  1 sibling, 0 replies; 4+ messages in thread
From: Alexander Schmidt @ 2010-01-27 17:01 UTC (permalink / raw)
  To: Roland Dreier, Linux RDMA
  Cc: lkml, Stefan Roscher, Joachim Fenkes, Christoph Raisch,
	Hoang-Nam Nguyen, David Wilder

The irq_spinlock is only taken in tasklet context, so it is safe not to
disable hardware interrupts.

Signed-off-by: Alexander Schmidt <alexs-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 drivers/infiniband/hw/ehca/ehca_irq.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- linux-2.6.orig/drivers/infiniband/hw/ehca/ehca_irq.c
+++ linux-2.6/drivers/infiniband/hw/ehca/ehca_irq.c
@@ -548,11 +548,10 @@ void ehca_process_eq(struct ehca_shca *s
 	struct ehca_eq *eq = &shca->eq;
 	struct ehca_eqe_cache_entry *eqe_cache = eq->eqe_cache;
 	u64 eqe_value, ret;
-	unsigned long flags;
 	int eqe_cnt, i;
 	int eq_empty = 0;
 
-	spin_lock_irqsave(&eq->irq_spinlock, flags);
+	spin_lock(&eq->irq_spinlock);
 	if (is_irq) {
 		const int max_query_cnt = 100;
 		int query_cnt = 0;
@@ -643,7 +642,7 @@ void ehca_process_eq(struct ehca_shca *s
 	} while (1);
 
 unlock_irq_spinlock:
-	spin_unlock_irqrestore(&eq->irq_spinlock, flags);
+	spin_unlock(&eq->irq_spinlock);
 }
 
 void ehca_tasklet_eq(unsigned long data)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ib/ehca: allow access for ib_query_qp()
  2010-01-27 17:00 [PATCH 0/2] ib/ehca: fixes for -next Alexander Schmidt
  2010-01-27 17:01 ` [PATCH 1/2] ib/ehca: Do not turn off irqs in tasklet context Alexander Schmidt
@ 2010-01-27 17:03 ` Alexander Schmidt
  2010-02-12 23:25   ` Roland Dreier
  1 sibling, 1 reply; 4+ messages in thread
From: Alexander Schmidt @ 2010-01-27 17:03 UTC (permalink / raw)
  To: Roland Dreier, Linux RDMA
  Cc: lkml, Stefan Roscher, Joachim Fenkes, Christoph Raisch,
	Hoang-Nam Nguyen, David Wilder

The max_dest_rd_atomic and max_qp_rd_atomic values are
properly returned by query_qp(), so there should not be
an error returned when they are queried.

Signed-off-by: Alexander Schmidt <alexs-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 drivers/infiniband/hw/ehca/ehca_qp.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- linux-2.6.orig/drivers/infiniband/hw/ehca/ehca_qp.c
+++ linux-2.6/drivers/infiniband/hw/ehca/ehca_qp.c
@@ -55,9 +55,7 @@ static struct kmem_cache *qp_cache;
 /*
  * attributes not supported by query qp
  */
-#define QP_ATTR_QUERY_NOT_SUPPORTED (IB_QP_MAX_DEST_RD_ATOMIC | \
-				     IB_QP_MAX_QP_RD_ATOMIC   | \
-				     IB_QP_ACCESS_FLAGS       | \
+#define QP_ATTR_QUERY_NOT_SUPPORTED (IB_QP_ACCESS_FLAGS       | \
 				     IB_QP_EN_SQD_ASYNC_NOTIFY)
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ib/ehca: allow access for ib_query_qp()
  2010-01-27 17:03 ` [PATCH 2/2] ib/ehca: allow access for ib_query_qp() Alexander Schmidt
@ 2010-02-12 23:25   ` Roland Dreier
  0 siblings, 0 replies; 4+ messages in thread
From: Roland Dreier @ 2010-02-12 23:25 UTC (permalink / raw)
  To: Alexander Schmidt
  Cc: Linux RDMA, lkml, Stefan Roscher, Joachim Fenkes,
	Christoph Raisch, Hoang-Nam Nguyen, David Wilder

applied 1 & 2, thanks
-- 
Roland Dreier  <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-02-12 23:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 17:00 [PATCH 0/2] ib/ehca: fixes for -next Alexander Schmidt
2010-01-27 17:01 ` [PATCH 1/2] ib/ehca: Do not turn off irqs in tasklet context Alexander Schmidt
2010-01-27 17:03 ` [PATCH 2/2] ib/ehca: allow access for ib_query_qp() Alexander Schmidt
2010-02-12 23:25   ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox