From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Bart Van Assche <bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: OFED mailing list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [ofa-general] [Bug 14235] New: SRP initiator lockup
Date: Sat, 05 Dec 2009 13:49:58 -0800 [thread overview]
Message-ID: <adatyw5t7jt.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <e2e108260912050944k1228e964ta7a70dde493ba010-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Bart Van Assche's message of "Sat, 5 Dec 2009 18:44:22 +0100")
> I'm not sure that the non-error path for ordinary SCSI commands is
> that trivial. If my interpretation of the SRP initiator source code is
> correct, the statements complete(&target->done) and
> init_completion(&target->done) can be executed concurrently. Although
> I do not know what the exact consequences are, and although I do not
> know whether this is related to the issue I reported, this is a race
> condition. I'm not sure that allowing such races is good kernel
> programming practice.
target->done is only used in connection setup I think, so not related to
hangs during IO processing. However I would like to know more details
of where you see this race, since yes we would want to fix that.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-05 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-14235-11804@http.bugzilla.kernel.org/>
2009-09-28 16:27 ` [ofa-general] [Bug 14235] New: SRP initiator lockup Roland Dreier
[not found] ` <ada63b3xcdt.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-12-05 17:44 ` Bart Van Assche
[not found] ` <e2e108260912050944k1228e964ta7a70dde493ba010-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-05 21:49 ` Roland Dreier [this message]
[not found] ` <adatyw5t7jt.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2009-12-06 11:02 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatyw5t7jt.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox