From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Vu Pham <vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Linux RDMA list <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [ofa-general][PATCH 2/4] SRP fail-over faster
Date: Wed, 14 Oct 2009 13:29:13 -0700 [thread overview]
Message-ID: <adatyy190ti.fsf@cisco.com> (raw)
In-Reply-To: <4AD62D9D.1020900-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> (Vu Pham's message of "Wed, 14 Oct 2009 12:59:25 -0700")
> > > - wait_for_completion(&target->done);
> >
> > How do you avoid leaking connection on module unload etc? Don't we have
> > to wait for the disconnect to finish somewhere?
> >
> > - R.
> >
> Are you talking about cm_id?
> I think that we wait because we want to reuse cq/qp associate with the
> connection.
> On module unload, we destroy cm_id, cq, qp altogether.
OK, I think I understand this piece locally (although if you delete the
wait_for_completion() it would probably make more sense to delete the
init_completion() just before it as well).
However is it really a correct to reuse a cm_id that is in state
timewait to initiate a new connection? That seems pretty fragile to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-10-14 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 22:57 [ofa-general][PATCH 2/4] SRP fail-over faster Vu Pham
[not found] ` <4AD3B443.7040107-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2009-10-14 18:04 ` Roland Dreier
[not found] ` <ada63aham2r.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-14 19:59 ` Vu Pham
[not found] ` <4AD62D9D.1020900-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2009-10-14 20:29 ` Roland Dreier [this message]
[not found] ` <adatyy190ti.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-14 21:00 ` Vu Pham
2009-10-22 23:08 ` Vu Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatyy190ti.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vuhuong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox