From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: mlx4 fix for 36-bit bus addresses on 32-bit arch Date: Fri, 14 Jan 2011 13:26:33 -0800 Message-ID: References: <4D2D5FAD.6030508@cadence.com> <20110114130903.GA29706@mtldesk30> <20110114172721.GB16535@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20110114172721.GB16535-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> (Jason Gunthorpe's message of "Fri, 14 Jan 2011 10:27:21 -0700") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Eli Cohen , "J.L. Burr" , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yevgeny Petrilin , Vladimir Sokolovsky , Eli Cohen List-Id: linux-rdma@vger.kernel.org > > Regardless of whether what I say above is correct or not, wouldn't it > > be nicer to to define pfn as either u64 or phys_addr_t and avoid the > > casting? > > Good point, the pfn must be stored as phys_addr_t too, otherwise you > only support a 44 bit physical address space before truncatation > occures. Not sure I agree at the moment... eg remap_pfn_range takes unsigned long. So I don't think things will really work on a 32-bit arch with > 44 bit bus addresses for lots of other reasons. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html