From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files. Date: Wed, 29 Sep 2010 10:19:32 -0700 Message-ID: References: <20100929141112.26944.21931.stgit@build.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20100929141112.26944.21931.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org> (Steve Wise's message of "Wed, 29 Sep 2010 09:11:12 -0500") Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Wise Cc: Arnd Bergmann , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > @@ -182,6 +182,7 @@ static const struct file_operations qp_debugfs_fops = { > .open = qp_open, > .release = qp_release, > .read = debugfs_read, > + .llseek = default_llseek, > }; I think this could actually be generic_file_llseek (right, Arnd?). Also could qp_read() and other read methods be simplified by using simple_read_from_buffer()? I don't see anything fancy there, seems like the read methods could become one-liners that way. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html