From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Ralph Campbell <ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Cc: "linux-kernel@vger.kernel.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-rdma@vger.kernel.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: InfiniBand/RDMA merge plans for 2.6.33
Date: Wed, 16 Dec 2009 09:20:01 -0800 [thread overview]
Message-ID: <adaws0m96pq.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <1260821358.19688.296.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org> (Ralph Campbell's message of "Mon, 14 Dec 2009 12:09:18 -0800")
> I understand your frustration in having to deal with a large amount
> of code. If you included all the Mellanox firmware in the mlx4
> driver, it would be huge too. I'm limited in what I can do given
> the complexity of the IBTA spec.
Sure, I understand that your driver is going to be pretty big. However,
ipath was ~38 KLoC, which qib is ~54 KLoC (after the latest cleanup --
it started over 60K if I recall correctly). That's 40% bigger, 16 KLoC
in absolute terms -- and you dropped support for HT HCAs!
> QLogic is not "abandoning the ipath driver as unmaintainable".
> The thought was that trying to incrementally patch in all the changes
> needed to support dual ports, QDR, chip register addresses, etc.
> would result in larger patches than renaming the driver. It was a
> chicken-and-egg problem because until the new code was fully
> written and debugged, we couldn't post it and we couldn't patch
> ipath until we knew all the places that needed to be changed.
We can quibble about the reason, but the end effect is that ipath is
abandonded, right? Maybe a better approach would have been to write a
new driver for the new chip and not try to move the old devices out of
ipath. But of course it's way too late to start over.
Anyway, we'll get qib in eventually -- but it may take some work.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-16 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 18:37 InfiniBand/RDMA merge plans for 2.6.33 Roland Dreier
[not found] ` <adaocm1csgb.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2009-12-14 20:09 ` Ralph Campbell
[not found] ` <1260821358.19688.296.camel-/vjeY7uYZjrPXfVEPVhPGq6RkeBMCJyt@public.gmane.org>
2009-12-16 17:20 ` Roland Dreier [this message]
2009-12-15 8:34 ` Eli Cohen
2009-12-16 5:54 ` Or Gerlitz
2009-12-16 9:03 ` Tziporet Koren
[not found] ` <4B28A259.3040909-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2009-12-16 17:15 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaws0m96pq.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralph.campbell-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox